Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: fix for None platform CI #1004

Merged
merged 1 commit into from
Jul 30, 2021
Merged

NO-ISSUE: fix for None platform CI #1004

merged 1 commit into from
Jul 30, 2021

Conversation

tsorya
Copy link
Contributor

@tsorya tsorya commented Jul 29, 2021 •
edited
Loading

Configure DNS on none-platform before waiting for AI to be ready for install

Since new DNS validations have been added to AI for none-platform installations,
AI will not become ready to install until DNS is properly configured.

Until now, the test infra configured the DNS entries for none-platform
only AFTER it waited for AI to become ready. But now AI will not become
ready until those DNS entries have been configured. This caused the waiting
function to time-out in none-platform tests ever since the DNS
validations PR has been merged.

This commit fixes that problem by configuring the relevant DNS entries before
waiting for AI to become ready.

References:
openshift/assisted-service#1884 - DNS Validations PR

@tsorya
Copy link
Contributor Author

tsorya commented Jul 29, 2021

/test ?

@openshift-ci
Copy link

openshift-ci bot commented Jul 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tsorya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from omertuc and ronniel1 July 29, 2021 17:29
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 29, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 29, 2021

@tsorya: The following commands are available to trigger required jobs:

  • /test e2e-metal-assisted
  • /test e2e-metal-assisted-kube-api
  • /test images

The following commands are available to trigger optional jobs:

  • /test e2e-metal-assisted-ipv6
  • /test e2e-metal-assisted-none
  • /test e2e-metal-assisted-none-ipv6
  • /test e2e-metal-assisted-olm
  • /test e2e-metal-assisted-single-node
  • /test e2e-metal-single-node-live-iso
  • /test system-test-operator

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api
  • pull-ci-openshift-assisted-test-infra-master-images

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tsorya
Copy link
Contributor Author

tsorya commented Jul 29, 2021

/test e2e-metal-assisted-single-node

@tsorya
Copy link
Contributor Author

tsorya commented Jul 29, 2021

/test e2e-metal-assisted-none

@omertuc
Copy link
Contributor

omertuc commented Jul 29, 2021 •
edited
Loading

Already tried to do it myself and wrote this commit message, please use it:

Configure DNS on none-platform before waiting for AI to be ready for install

Since new DNS validations have been added to AI for none-platform installations,
AI will not become ready to install until DNS is properly configured.

Until now, the test infra configured the DNS entries for none-platform
only AFTER it waited for AI to become ready. But now AI will not become
ready until those DNS entries have been configured. This caused the waiting
function to time-out in none-platform tests ever since the DNS
validations PR has been merged.

This commit fixes that problem by configuring the relevant DNS entries before
waiting for AI to become ready.

References:
https://github.com/openshift/assisted-service/pull/1884 - DNS Validations PR

@tsorya
Copy link
Contributor Author

tsorya commented Jul 29, 2021

/test e2e-metal-assisted-none

@tsorya tsorya force-pushed the igal/fix_none_platform_ci branch from ad49308 to 28ca9f8 Compare July 29, 2021 21:36
@tsorya
Copy link
Contributor Author

tsorya commented Jul 29, 2021

/test e2e-metal-assisted-single-node

@tsorya
Copy link
Contributor Author

tsorya commented Jul 29, 2021

/test e2e-metal-assisted-none

@tsorya
NO-ISSUE: fix for None platform CI
62415c4 
Configure DNS on none-platform before waiting for AI to be ready for install

Since new DNS validations have been added to AI for none-platform installations,
AI will not become ready to install until DNS is properly configured.

Until now, the test infra configured the DNS entries for none-platform
only AFTER it waited for AI to become ready. But now AI will not become
ready until those DNS entries have been configured. This caused the waiting
function to time-out in none-platform tests ever since the DNS
validations PR has been merged.

This commit fixes that problem by configuring the relevant DNS entries before
waiting for AI to become ready.

References:
openshift/assisted-service#1884 - DNS Validations PR
@tsorya tsorya force-pushed the igal/fix_none_platform_ci branch from 28ca9f8 to 62415c4 Compare July 30, 2021 04:36
@tsorya
Copy link
Contributor Author

tsorya commented Jul 30, 2021

/test e2e-metal-assisted-single-node
/test e2e-metal-assisted-none

@omertuc
Copy link
Contributor

omertuc commented Jul 30, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2021
@openshift-ci openshift-ci bot merged commit 3ffd245 into openshift:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omertuc omertuc Awaiting requested review from omertuc

@ronniel1 ronniel1 Awaiting requested review from ronniel1

Assignees

@omertuc omertuc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsorya @omertuc