Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-20025: Replace encode from yaml to json on Nutanix types #7353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MGMT-20025: Replace encode from yaml to json on Nutanix types #7353

wants to merge 1 commit into from

Conversation

mlorenzofr
Copy link
Contributor

@mlorenzofr mlorenzofr commented Feb 26, 2025 •
edited
Loading

This PR fixes a bug unmarshalling the install-config generated by the assisted-service due to an error in Nutanix type encoding.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (tested on Nutanix platform with CAPI)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 26, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2025 •
edited by openshift-ci bot
Loading

@mlorenzofr: This pull request references MGMT-20025 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (tested on Nutanix platform with CAPI)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 26, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlorenzofr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2025
@mlorenzofr
Copy link
Contributor Author

/assign @rccrdpccl

@codecov Codecov
Copy link

codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.97%. Comparing base (39bc1ae) to head (5fbf17c).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7353   +/-   ##
=======================================
  Coverage   67.97%   67.97%           
=======================================
  Files         300      300           
  Lines       41014    41013    -1     
=======================================
  Hits        27878    27878           
+ Misses      10633    10632    -1     
  Partials     2503     2503

see 5 files with indirect coverage changes

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2025 •
edited by openshift-ci bot
Loading

@mlorenzofr: This pull request references MGMT-20025 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

This PR fixes a bug unmarshalling the install-config generated by the assisted-service due to an error in Nutanix type encoding.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (tested on Nutanix platform with CAPI)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mlorenzofr mlorenzofr force-pushed the mgmt-20025 branch 2 times, most recently from 787f358 to 3edce81 Compare February 26, 2025 21:52
@gamli75
Copy link
Contributor

gamli75 commented Feb 26, 2025

@eliorerz please review
@mlorenzofr you need to run nutanix e2e test

@rccrdpccl
Copy link
Contributor

/test ?

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 27, 2025

@rccrdpccl: The following commands are available to trigger required jobs:

/test e2e-agent-compact-ipv4

/test edge-assisted-operator-catalog-publish-verify

/test edge-ci-index

/test edge-e2e-ai-operator-disconnected-capi

/test edge-e2e-ai-operator-ztp

/test edge-e2e-ai-operator-ztp-3masters

/test edge-e2e-ai-operator-ztp-capi

/test edge-e2e-ai-operator-ztp-disconnected

/test edge-e2e-metal-assisted-4-14

/test edge-e2e-metal-assisted-4-15

/test edge-e2e-metal-assisted-4-16

/test edge-e2e-metal-assisted-4-17

/test edge-e2e-metal-assisted-4-18

/test edge-e2e-metal-assisted-5-control-planes-4-18

/test edge-e2e-metal-assisted-cnv-4-17

/test edge-e2e-metal-assisted-external-4-18

/test edge-e2e-metal-assisted-lvm-4-18

/test edge-e2e-metal-assisted-mtv-4-17

/test edge-e2e-metal-assisted-none-4-18

/test edge-e2e-metal-assisted-odf-4-17

/test edge-e2e-metal-assisted-osc-4-18

/test edge-e2e-nutanix-assisted-2workers-4-18

/test edge-e2e-nutanix-assisted-4-18

/test edge-e2e-vsphere-assisted-4-18

/test edge-images

/test edge-lint

/test edge-operator-publish-verify

/test edge-subsystem-aws

/test edge-subsystem-kubeapi-aws

/test edge-unit-test

/test edge-verify-generated-code

/test images

/test mce-images

The following commands are available to trigger optional jobs:

/test e2e-agent-4control-ipv4

/test e2e-agent-5control-ipv4

/test e2e-agent-ha-dualstack

/test e2e-agent-sno-ipv6

/test edge-e2e-ai-operator-ztp-4masters

/test edge-e2e-ai-operator-ztp-5masters

/test edge-e2e-ai-operator-ztp-compact-day2-masters

/test edge-e2e-ai-operator-ztp-compact-day2-workers

/test edge-e2e-ai-operator-ztp-hypershift-zero-nodes

/test edge-e2e-ai-operator-ztp-multiarch-3masters-ocp

/test edge-e2e-ai-operator-ztp-multiarch-sno-ocp

/test edge-e2e-ai-operator-ztp-node-labels

/test edge-e2e-ai-operator-ztp-remove-node

/test edge-e2e-ai-operator-ztp-sno-day2-masters

/test edge-e2e-ai-operator-ztp-sno-day2-workers

/test edge-e2e-ai-operator-ztp-sno-day2-workers-ignitionoverride

/test edge-e2e-ai-operator-ztp-sno-day2-workers-late-binding

/test edge-e2e-metal-assisted-4-control-planes-4-18

/test edge-e2e-metal-assisted-4-masters-none-4-18

/test edge-e2e-metal-assisted-bond-4-14

/test edge-e2e-metal-assisted-bond-4-18

/test edge-e2e-metal-assisted-day2-4-18

/test edge-e2e-metal-assisted-day2-arm-workers-4-18

/test edge-e2e-metal-assisted-day2-sno-4-18

/test edge-e2e-metal-assisted-ipv4v6-4-18

/test edge-e2e-metal-assisted-ipv6-4-18

/test edge-e2e-metal-assisted-k8s-nmstate-4-17

/test edge-e2e-metal-assisted-kube-api-late-binding-sno-4-18

/test edge-e2e-metal-assisted-kube-api-late-unbinding-sno-4-18

/test edge-e2e-metal-assisted-kube-api-net-suite-4-18

/test edge-e2e-metal-assisted-kube-api-umlb-4-18

/test edge-e2e-metal-assisted-onprem-4-18

/test edge-e2e-metal-assisted-osc-sno-4-18

/test edge-e2e-metal-assisted-sno-4-18

/test edge-e2e-metal-assisted-static-ip-suite-4-14

/test edge-e2e-metal-assisted-static-ip-suite-4-18

/test edge-e2e-metal-assisted-tang-4-18

/test edge-e2e-metal-assisted-tpmv2-4-18

/test edge-e2e-metal-assisted-umlb-4-18

/test edge-e2e-metal-assisted-upgrade-agent-4-18

/test edge-e2e-oci-assisted-4-18

/test edge-e2e-oci-assisted-bm-iscsi-4-18

/test edge-e2e-vsphere-assisted-umlb-4-18

/test edge-e2e-vsphere-assisted-umn-4-18

/test okd-scos-e2e-aws-ovn

/test okd-scos-images

/test push-pr-image

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4

pull-ci-openshift-assisted-service-master-edge-ci-index

pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp

pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-4-18

pull-ci-openshift-assisted-service-master-edge-images

pull-ci-openshift-assisted-service-master-edge-lint

pull-ci-openshift-assisted-service-master-edge-subsystem-aws

pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws

pull-ci-openshift-assisted-service-master-edge-unit-test

pull-ci-openshift-assisted-service-master-edge-verify-generated-code

pull-ci-openshift-assisted-service-master-images

pull-ci-openshift-assisted-service-master-mce-images

pull-ci-openshift-assisted-service-master-okd-scos-e2e-aws-ovn

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rccrdpccl
Copy link
Contributor

/test edge-e2e-nutanix-assisted-4-18

@rccrdpccl
Copy link
Contributor

/retest

@rccrdpccl
Copy link
Contributor

nice 😍

@eliorerz
Copy link
Contributor

/hold
Currently, our CI for Nutanix is broken. If this PR is not urgent, I think it is best to hold off on merging it until our CI is fixed.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2025
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2025
@rccrdpccl
Copy link
Contributor

Currently, our CI for Nutanix is broken. If this PR is not urgent, I think it is best to hold off on merging it until our CI is fixed.

@eliorerz I guess it's not urgent because it has been broken since forever, but we are breaking most nutanix installations as we currently produce an invalid install config

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 27, 2025

@mlorenzofr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/edge-e2e-nutanix-assisted-4-18 5fbf17c link true /test edge-e2e-nutanix-assisted-4-18

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ori-amizur ori-amizur Awaiting requested review from ori-amizur

@pastequo pastequo Awaiting requested review from pastequo

Assignees

@rccrdpccl rccrdpccl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mlorenzofr @openshift-ci-robot @gamli75 @rccrdpccl @eliorerz