-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-20022: Handle missing ManagedCluster in non MCE environments #7348
base: master
Are you sure you want to change the base?
Conversation
@paul-maidment: This pull request references MGMT-20022 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paul-maidment The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a0297b7
to
0276b59
Compare
When running the infrastructure operator in a non MCE environment it is possible to encounter an error due to the missing CRD. This error is cryptic and hard to understand. This PR clears that up by raising an error if the ManagedCluster CRD is not in the cluster. Additionally, this has been added to deploy/operator so that this CRD is installed whenever that operator is installed using this script.
0276b59
to
a810732
Compare
When running the infrastructure operator in a non MCE environment it is possible to encounter an error due to the missing CRD. This error is cryptic and hard to understand.
This PR clears that up by raising an error if the ManagedCluster CRD is not in the cluster.
Additionally, this has been added to deploy/operator so that this CRD is installed whenever that operator is installed using this script.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist