OCPEDGE-1311: add two node openshift deployment #7321
Conversation
Add new deployment type to the assisted service called two node with arbiter(TNA)
openshift-ci-robot
added
the
jira/valid-reference
|
@qJkee: This pull request references OCPEDGE-1311 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/S
openshift-ci
bot
added
the
api-review
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: qJkee The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7321 +/- ##
==========================================
- Coverage 67.96% 67.95% -0.02%
==========================================
Files 300 300
Lines 41007 41023 +16
==========================================
+ Hits 27872 27878 +6
- Misses 10632 10641 +9
- Partials 2503 2504 +1
|
|
Are we additionally expected to deploy the arbiter node? How is that being handled? |
| @@ -112,6 +112,18 @@ func (i *installConfigBuilder) getBasicInstallConfig(cluster *common.Cluster) (* | |||
| SSHKey: cluster.SSHPublicKey, | |||
| } | |||
|
|
|||
| if cfg.ControlPlane.Replicas == 2 { | |||
There was a problem hiding this comment.
How will we differentiate between the arbiter case and the two node with fencing case once that comes through?
| @@ -41,14 +41,17 @@ const ( | |||
|
|
|||
| // HostRoleBootstrap captures enum value "bootstrap" | |||
| HostRoleBootstrap HostRole = "bootstrap" | |||
|
|
|||
| // HostRoleArbiter captures enum value "arbiter" | |||
| HostRoleArbiter HostRole = "arbiter" | |||
There was a problem hiding this comment.
How does this role get assigned?
There was a problem hiding this comment.
After reading more of the enhancement it does seem like we'll need significantly more changes to support this.
We'll need to update host minimum requirements for the arbiter role, we'll need to support reading the new ignition from the installer and ensuring the host designated as the arbiter downloads it, and we'll probably also need some way to ensure this is gated to only openshift versions that support TNA
|
@qJkee: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Add new deployment type to the assisted service called two node with arbiter(TNA). Install config changes are made according to openshift/enhancements#1674 proposal
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist