NO-ISSUE: Ensure that hard links are accounted for when measuring disk usage

[paul-maidment]

When we measure the disk usage for metrics, we need to ensure that hard links are accounted for as these may lead to an inaccurate count. This PR modifies the gathering of filesizes slightly to perform a stat on each file and take into account the unique inode number.

Hard links and actual files share the same inode number as this is a reference to the underlying data.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@paul-maidment: This pull request explicitly references no jira issue.

In response to this:

…k usage.

When we measure the disk usage for metrics, we need to ensure that hard links are accounted for as these may lead to an inaccurate count. This PR modifies the gathering of filesizes slightly to perform a stat on each file and take into account the unique inode number.

Hard links and actual files share the same inode number as this is a reference to the underlying data.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paul-maidment

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [paul-maidment]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rccrdpccl]

/lgtm

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.89%. Comparing base (cc75f5f) to head (6ac1134).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
internal/metrics/disk_stats_helper.go	66.66%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7217   +/-   ##
=======================================
  Coverage   67.88%   67.89%           
=======================================
  Files         298      298           
  Lines       40666    40671    +5     
=======================================
+ Hits        27607    27612    +5     
  Misses      10588    10588           
  Partials     2471     2471           

Files with missing lines	Coverage Δ
internal/metrics/disk_stats_helper.go	71.42% <66.66%> (-2.49%)	⬇️

... and 1 file with indirect coverage changes

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD cc75f5f and 2 for PR HEAD 6ac1134 in total

[paul-maidment]

/retest

[pastequo]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9df3014 and 2 for PR HEAD 6ac1134 in total

[paul-maidment]

/test edge-subsystem-kubeapi-aws

[openshift-ci]

@paul-maidment: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-api-server
This PR has been included in build ose-agent-installer-api-server-container-v4.19.0-202501231608.p0.gf8e3e31.assembly.stream.el9.
All builds following this will include this PR.