MGMT-3959 Support overriding newer release images #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YuviGold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Please write a short description of what you're trying to achieve |
Updated. |
omertuc
reviewed
Feb 8, 2021
Remove the override logic from the Go code and made the handle_ocp_versions.py utility to update JSONs. In case of overriding an existing major.minor - it would just replace the displayName and releaseImage fields. In case of a new image (new major.minor) - it would copy the biggest semver version metadata (i.e. rhcosVersion)
YuviGold
force-pushed
the
MGMT-3959-support-override-newer-images
branch
from
ec60339 to
a0ba583
Compare
|
/lgtm |
mkowalski
pushed a commit
to mkowalski/assisted-service
that referenced
this pull request
May 21, 2021
* update tools for running local bmo Have the run script build a development version of the deployment for metal3 by looking at the production one and removing the bmo and some other settings we don't want. Wait longer for the new pod to run, since we now wait for the init container to download RHCOS. Log output. Signed-off-by: Doug Hellmann <dhellmann@redhat.com> * make it possible to override the logging destination directory Signed-off-by: Doug Hellmann <dhellmann@redhat.com> * add stop script for dev metal3 deployment Signed-off-by: Doug Hellmann <dhellmann@redhat.com> * add script to bring mao back under cvo control Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the assisted-service only supports overriding an image that is already supported (major.minor).
We need to support experiencing with even newer images.
Otherwise, the CI would complain once in a while about newer versions being tested that are unsupported.
Eventually, I removed the override from the Go code and I made the
handle_ocp_versions.pyutility to update JSONs.In case of overriding an existing
major.minor- it would just replace thedisplayNameandreleaseImagefields.In case of a new image (new
major.minor) - it would copy the biggest semver version metadata (i.e.rhcosVersion)