Skip to content

Conversation

@ffromani
Copy link

This feature gate will make the kubelet to actually accept
the policy options; until some agent configures them
in the kubelet config file, no change of behaviour will
happen at all.

Signed-off-by: Francesco Romani fromani@redhat.com

This feature gate will make the kubelet to actually accept
the policy options; until some agent configures them
in the kubelet config file, no change of behaviour will
happen at all.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fromanirh
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from derekwaynecarr and mfojtik July 19, 2021 13:27
@rphillips
Copy link
Contributor

This PR needs the 1.22 rebase. Let's hold it until that time.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2021
@ffromani
Copy link
Author

/test verify
I'm pretty sure the failure was a hiccup

@ffromani
Copy link
Author

/hold cancel
because openshift/kubernetes#862 merged

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2021
@ffromani
Copy link
Author

I will file the BZ ASAP

@ffromani ffromani changed the title feature: Enable the CPUManagerPolicyOptions by default BUG 1992599: feature: Enable the CPUManagerPolicyOptions by default Aug 11, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@fromanirh: This pull request references Bugzilla bug 1992599, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 1992599: feature: Enable the CPUManagerPolicyOptions by default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ffromani
Copy link
Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@fromanirh: This pull request references Bugzilla bug 1992599, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ffromani
Copy link
Author

ffromani commented Oct 5, 2021

we will wait for kube 1.23 and we will re-evaluate

@ffromani ffromani closed this Oct 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2021

@fromanirh: An error was encountered removing this pull request from the external tracker bugs for bug 1992599 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. JSONRPC error 32000: Subcomponet is mandatory for the component 'Machine Config Operator' in the product 'OpenShift Container Platform'.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

BUG 1992599: feature: Enable the CPUManagerPolicyOptions by default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants