Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding subresources/status to imagepruner crd #561

Merged
merged 1 commit into from
Jan 9, 2020
Merged

adding subresources/status to imagepruner crd #561

merged 1 commit into from
Jan 9, 2020

Conversation

coreydaley
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 9, 2020
@coreydaley
Copy link
Member Author

/assign @bparees @adambkaplan

adambkaplan
adambkaplan approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

See my comment on the kubebuilder tag (can our tooling take advantage of this?)

imageregistry/v1/01-crd.yaml
@@ -7,6 +7,8 @@ spec:
scope: Cluster
version: v1
preserveUnknownFields: false
subresources:
status: {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sttts @soltysh would adding the +kubebuilder:subresource:status tag to the object generate this for us automatically?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not running full generation, so this won't help, but it worthy adding in the nearest future.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2020
soltysh
soltysh approved these changes Jan 9, 2020
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2020
@bparees
Copy link
Contributor

bparees commented Jan 9, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees, coreydaley, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 35a64c7 into openshift:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@adambkaplan adambkaplan adambkaplan approved these changes

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

Assignees

@adambkaplan adambkaplan

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@coreydaley @bparees @openshift-ci-robot @soltysh @adambkaplan @openshift-merge-robot