OAPE-232/OCPBUGS-55653: Remove GCPLabelsTags featuregate

[bharath-b-rh]

The PR is for removing the GCPLabelsTags featuregate, which was introduced for managing the new features for configuring GCP Labels and Tags in Infrastructure API and referenced in o/operators and o/installer.

Featuregate references was removed in openshift operators and openshift installer in v4.18, and removing the featuregate definition in this PR.

[openshift-ci]

Hello @bharath-b-rh! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@bharath-b-rh: This pull request references Jira Issue OCPBUGS-55653, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The PR is for removing the GCPLabelsTags featuregate, which was introduced for managing the new features for configuring GCP Labels and Tags in Infrastructure API and referenced in o/operators and o/installer.

Featuregate references was removed in openshift operators and openshift installer in v4.18, and removing the featuregate definition in this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bharath-b-rh]

/cc @barbacbd @JoelSpeed

[JoelSpeed]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-b-rh, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD cb94c55 and 2 for PR HEAD 8fa54b5 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1c8afbd and 1 for PR HEAD 8fa54b5 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1c8afbd and 2 for PR HEAD 8fa54b5 in total

[bharath-b-rh]

/retest-required

[bharath-b-rh]

/test e2e-aws-ovn-techpreview

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD ef565c2 and 1 for PR HEAD 8fa54b5 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a8cbc21 and 0 for PR HEAD 8fa54b5 in total

[openshift-ci-robot]

/hold

Revision 8fa54b5 was retested 3 times: holding

[barbacbd]

/retest

[JoelSpeed]

/retest-required

[bharath-b-rh]

All the CI jobs are failing with same error with few operators like console, ingress reporting degraded status. I will check the failures in detail next Monday.

[JoelSpeed]

There's a panic in Machine API Operator as it is still relying on the GCPLabelsTags feature gate

[bharath-b-rh]

@JoelSpeed Thank you for pointing out the issue! It is also referenced in both machine-api-operator and installer-aro, which I wasn't aware of. Let me create a PR in both projects to remove the reference.

It has references in other projects like hypershift, library-go too but in the tests sample data. I think those can be updated by project owners when api package is updated.

[bharath-b-rh]

/testwith openshift/machine-api-operator#1385

[bharath-b-rh]

/retest-required

[openshift-ci]

@bharath-b-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp	8fa54b5	link	false	/test e2e-gcp
ci/prow/okd-scos-e2e-aws-ovn	8fa54b5	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure	8fa54b5	link	false	/test e2e-azure
ci/prow/e2e-aws-serial-techpreview-2of2	8fa54b5	link	true	/test e2e-aws-serial-techpreview-2of2
ci/prow/e2e-aws-serial-1of2	8fa54b5	link	true	/test e2e-aws-serial-1of2
ci/prow/minor-e2e-upgrade-minor	8fa54b5	link	true	/test minor-e2e-upgrade-minor
ci/prow/e2e-aws-ovn	8fa54b5	link	true	/test e2e-aws-ovn
ci/prow/e2e-aws-ovn-techpreview	8fa54b5	link	true	/test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-serial-techpreview-1of2	8fa54b5	link	true	/test e2e-aws-serial-techpreview-1of2
ci/prow/e2e-upgrade-out-of-change	8fa54b5	link	true	/test e2e-upgrade-out-of-change
ci/prow/e2e-aws-serial-2of2	8fa54b5	link	true	/test e2e-aws-serial-2of2
ci/prow/e2e-upgrade	8fa54b5	link	true	/test e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.