-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-51077: [4.18] bump controller-tools dependency to latest downstream commit #2210
base: release-4.18
Are you sure you want to change the base?
OCPBUGS-51077: [4.18] bump controller-tools dependency to latest downstream commit #2210
Conversation
Hello @everettraven! Some important instructions when contributing to openshift/api: |
@everettraven: This pull request references Jira Issue OCPBUGS-51077, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@everettraven: This pull request references Jira Issue OCPBUGS-51077, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Looks like it may be easier to backport the change in controller-runtime to the 4.18 branch there, and then vendor that here, rather than vendoring the now master branch which is inline with 4.19 |
@JoelSpeed doesn't look like a 4.18 branch exists in https://github.com/openshift/kubernetes-sigs-controller-tools Is there a particular process I would need to follow to get that in place? |
Speak to the right people and branches may appear... check now? I've just pushed something that I think we can use, it's the state of the repo prior to the last rebase on upstream |
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
4c8a8d0
to
4e28da9
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@everettraven: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.