OPRUN-3401: Promote NewOLM to Default FeatureSet #2099
Conversation
|
@joelanford: This pull request references OPRUN-3401 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/hold
|
Hello @joelanford! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/XL
|
I've cloned this PR (#2101) - to kick CI over until you show up in the morning so we can burn these down. |
joelanford
force-pushed
the
newolm-default-payload
branch
from
60ed708 to
6cea01f
Compare
|
@perdasilva I updated this PR so that we stop showing up in Hypershift. @LalatenduMohanty will be submitting a new PR today in |
joelanford
force-pushed
the
newolm-default-payload
branch
from
6cea01f to
fdceee2
Compare
openshift-ci
bot
added
size/XXL
| productScope(ocpSpecific). | ||
| enhancementPR(legacyFeatureGateWithoutEnhancement). | ||
| enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade). | ||
| enableForClusterProfile(SelfManaged, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade, configv1.Default). |
There was a problem hiding this comment.
@joelanford I do not see SelfManaged in other feature gates. I am not sure why we need it here.
There was a problem hiding this comment.
This is supposed to make sure that we are only present in SelfManaged clusters. See https://github.com/openshift/api?tab=readme-ov-file#adding-new-techpreview-featuregate-to-all-only-hypershift, which is the closest example for what we're trying to do.
There was a problem hiding this comment.
I guess the definition is here: https://github.com/openshift/api/blob/master/features/util.go#L34-L38
Hypershift = ClusterProfileName("include.release.openshift.io/ibm-cloud-managed")
SelfManaged = ClusterProfileName("include.release.openshift.io/self-managed-high-availability")
AllClusterProfiles = []ClusterProfileName{Hypershift, SelfManaged}
|
@joelanford: This pull request references OPRUN-3401 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
joelanford
force-pushed
the
newolm-default-payload
branch
from
fdceee2 to
ce70fc5
Compare
| // +kubebuilder:object:root=true | ||
| // +kubebuilder:resource:path=olms,scope=Cluster | ||
| // +kubebuilder:subresource:status | ||
| // +kubebuilder:metadata:annotations=include.release.openshift.io/ibm-cloud-managed=false |
There was a problem hiding this comment.
Lets try adding the partner annotation and see if that brings the generation back
| // +kubebuilder:metadata:annotations=include.release.openshift.io/ibm-cloud-managed=false | |
| // +kubebuilder:metadata:annotations=include.release.openshift.io/ibm-cloud-managed=false | |
| // +kubebuilder:metadata:annotations=include.release.openshift.io/self-managed-high-availability: "true" |
There was a problem hiding this comment.
// +kubebuilder:metadata:annotations=include.release.openshift.io/self-managed-high-availability=true
|
/retest |
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
newolm-default-payload
branch
from
ce70fc5 to
917f3bf
Compare
openshift-ci
bot
added
size/XL
|
/test verify |
|
/retest |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-4.18-upgrade-from-stable-4.18-azure-ipi-proxy-tp-arm-f60 |
|
Pre-merge test fail, details: https://redhat-internal.slack.com/archives/C06KP34REFJ/p1732095507235489?thread_ts=1732077839.541179&cid=C06KP34REFJ |
|
/test ci/prow/verify |
|
@tmshort: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@perdasilva: The The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @JoelSpeed, can we override those non-required jobs and let it merge? Thanks! Once openshift/cluster-olm-operator#74 is merged, these failure test cases can pass. |
|
/test e2e-aws-serial |
|
@JoelSpeed can we override |
|
/hold we concluded some origin changes need to go in, and then this will likely need a green button merge simultaneously with openshift/cluster-olm-operator#74 |
openshift-ci
bot
added
the
do-not-merge/hold
|
Origin PR that needs to merge first: openshift/origin#29313 |
|
openshift/origin#29313 has merged |
|
openshift/origin#29313 and openshift/cluster-olm-operator#74 have merged. Proceeding now with a merge of this PR. /hold cancel
|
openshift-ci
bot
removed
the
do-not-merge/hold
|
/skip
|
|
@joelanford: Overrode contexts on behalf of joelanford: ci/prow/e2e-aws-serial In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-ovn |
|
@joelanford: Overrode contexts on behalf of joelanford: ci/prow/e2e-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/verify (see #2099 (comment)) |
|
@joelanford: Overrode contexts on behalf of joelanford: ci/prow/verify, ci/prow/verify-crd-schema In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/verify (see #2099 (comment)) |
|
@joelanford: Overrode contexts on behalf of joelanford: ci/prow/verify, ci/prow/verify-crd-schema In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold Revision 917f3bf was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/override ci/prow/e2e-aws-ovn-techpreview These tests are unlikely to pass until a payload containing openshift/cluster-olm-operator#74 is used as a basis. However the OLM team is concerned that openshift/cluster-olm-operator#74, by itself may fail tests. All engineering and QE validation testing was performed on a payload that included that PR and this PR together. As such, we are proceeding with a merge here because we believe the current state (where openshift/cluster-olm-operator#74 is merged and this PR is not is more precarious than if we force merge this one) We will be watching builds closely and are in communication with TRT so a quick revert can happen if necessary. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@joelanford: Overrode contexts on behalf of joelanford: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-techpreview, ci/prow/e2e-aws-serial-techpreview, ci/prow/e2e-upgrade, ci/prow/minor-e2e-upgrade-minor In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@joelanford: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
9 participants
This PR promotes the
NewOLMfeature to theDefaultfeatureset for SelfManaged clusters. OLMv1 is not ready to be included in Hypershift clusters. The regenerated CRDs will only be pulled into the payload after this PR merges and is incorporated into openshift/cluster-olm-operator#74/hold
Holding until we are ready for this to merge (we have a few other tasks to execute first)