OCPEDGE-1307: feat: add HighlyAvailableArbiter control plane topology as feature for techpreview #2082
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Hello @eggfoobar! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/XXL
eggfoobar
force-pushed
the
feature-arbiter-role
branch
2 times, most recently
from
57952e7 to
c174c2e
Compare
eggfoobar
force-pushed
the
feature-arbiter-role
branch
from
c174c2e to
4b367a7
Compare
eggfoobar
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@eggfoobar: This pull request references OCPEDGE-1307 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
eggfoobar
force-pushed
the
feature-arbiter-role
branch
from
4b367a7 to
658bfe2
Compare
openshift-merge-robot
added
the
needs-rebase
eggfoobar
force-pushed
the
feature-arbiter-role
branch
from
658bfe2 to
35af750
Compare
openshift-merge-robot
removed
the
needs-rebase
eggfoobar
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@eggfoobar: This pull request references OCPEDGE-1307 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
eggfoobar
force-pushed
the
feature-arbiter-role
branch
4 times, most recently
from
3329388 to
eba1ad6
Compare
| // +kubebuilder:validation:Enum=HighlyAvailable;SingleReplica;External | ||
| // +openshift:validation:FeatureGateAwareEnum:featureGate="",enum=HighlyAvailable;SingleReplica;External | ||
| // +openshift:validation:FeatureGateAwareEnum:featureGate=HighlyAvailableArbiter,enum=HighlyAvailable;HighlyAvailableArbiter;SingleReplica;External | ||
| ControlPlaneTopology TopologyMode `json:"controlPlaneTopology"` |
There was a problem hiding this comment.
This field should not be able to modified day 2 right? The test you have in place shows that it can be changed. Your proposal explicitly calls out that this cannot be changed day 2, so why does that test pass?
In general, I think this field should never have been mutable, perhaps we just need to make it immutable
There was a problem hiding this comment.
Ah, this was an older test where we originally had planned to update in the future (i.e moving from arbiter cluster to regular 3Node cluster), but regardless of that, to my knowledge we don't have something that enforces the status of ControlPlaneTopology, so that's why this test passes.
Changing this status is not supported in the current version of OCP, and I don't know if it would be a problem to make it immutable for the time being, since I think that would be a behavior change that some components might be relying on, for example I don't know if during bootstrap this ever gets applied then changed.
There was a problem hiding this comment.
I'm going to bring this up at the control plane arch call today and see what we think. IMO, this should always have been marked as immutable (once its set that is, "" -> ""` should be allowed)
…r techpreview Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
feature-arbiter-role
branch
from
eba1ad6 to
e566bcb
Compare
|
/override ci/prow/verify-crd-schema Pre-existing failures that cannot be resolved without breaking APIs /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eggfoobar, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
@eggfoobar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 54bdb80
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
5 participants
Adding HighlyAvailableArbiter FeatureGate for Control Plane Topology.
Per EP: openshift/enhancements#1674
This PR adds an authoritative flag to the control plane enums for HighlyAvailableArbiter which will denote a cluster that has at minimum 2 regular sized control plane nodes and 1 smaller control plane node called the arbiter