SDN-4930: Revert "OCPBUGS-38414: Revert #1988 "Graduate UserDefinedNetworks to GA""
#1997
Conversation
|
@tssurya: This pull request references SDN-4919 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
Hello @tssurya! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/S
|
/payload 4.18 ci blocking |
|
@tssurya: trigger 4 job(s) of type blocking for the ci release of OCP 4.18
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cef7fd70-5971-11ef-8e9c-fd73856402bf-0 trigger 10 job(s) of type blocking for the nightly release of OCP 4.18
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cef7fd70-5971-11ef-8e9c-fd73856402bf-1 |
|
/payload cancel |
|
/payload-abort |
|
@smg247: This PR was included in a payload test run from openshift/origin#28997
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/502783a0-5974-11ef-88ea-51e3322bf150-0 |
|
@smg247: This PR was included in a payload test run from openshift/origin#28997
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c93b2670-5974-11ef-94b4-ebabd8a793eb-0 |
|
/payload 4.18 ci blocking |
|
@tssurya: trigger 4 job(s) of type blocking for the ci release of OCP 4.18
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ebfdfce0-59f7-11ef-922d-84ad5312de64-0 trigger 9 job(s) of type blocking for the nightly release of OCP 4.18
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ebfdfce0-59f7-11ef-922d-84ad5312de64-1 |
|
@tssurya: This pull request references SDN-4919 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
openshift-ci
bot
added
the
qe-approved
|
@tssurya: This pull request references SDN-4919 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d5e52620-5a76-11ef-8cf6-cba82feaebc3-0 |
|
@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ea0bb010-5a76-11ef-8170-4812ecdc1d87-0 |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/payload 4.18 ci blocking |
|
@tssurya: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3fa07720-5e20-11ef-9a73-769c3cdb2a25-0 |
|
/test verify |
Are you trying to get more signal for the verify job? These won't contribute to it, since it's from a PR. It only considers signal from merged PR's. I can kick off a couple jobs if you need it. |
|
/test verify |
yeah how do I trigger techpreview vsphere jobs? I couldn't get the right job name :( |
|
/test verify |
1 similar comment
|
/test verify |
|
Only one test remaining that's not at the threshold - I kicked off 10x metal jobs to boost signal, should hopefully know in a few hours 
|
|
Apparently, bot can't build on this PR due to merge conflicts :( |
|
oopsy will rebase tomorrow |
|
@tssurya Can we rebase it so QE can build clusters on this build? It seems some CRD validations won't work unless we bring clusters with this API changes |
tssurya
force-pushed
the
revert-1996-revert-1988-1723548584685
branch
from
733cabf
to
10f739b
Compare
|
New changes are detected. LGTM label has been removed. |
|
@anuragthehatter see if it works now? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anuragthehatter, tssurya The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc |
huh |
|
/test verify |
Apparently still fails https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1843985077655048192 |
|
@tssurya Thats works. But I am concern about if we can merge asap becuase QE at the moment plays ping-pong with cluster bot builds, one fails one pass etc |
|
Unfortunately I also got to know this rule only last release but until a feature is FULLY done we can't GA. I can have segmented FG but that's too much work for us in ovnk. |
…tworks` to GA""
tssurya
force-pushed
the
revert-1996-revert-1988-1723548584685
branch
from
10f739b
to
6c35512
Compare
|
/retest |
tssurya
changed the title
UserDefinedNetworks to GA""UserDefinedNetworks to GA""
|
@tssurya: This pull request references SDN-4930 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tssurya: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Reverts #1996
openshift/origin#28997 has merged, I was on PTO and woke up to the revert, we already had the metal e2e fix in the pipe.
@huiran0826 @anuragthehatter : can you please check if metal jobs were run for the UDN feature? (update: QE has run all tests on all platforms)
The bug was in the e2e anyways not in the feature when revert happened. Also we wouldn't have caught it until we GA-ed it. So let's try this again.