-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-29774: Add Intermediate HyperShiftIndependent Profile #1900
base: master
Are you sure you want to change the base?
Conversation
@jupierce: This pull request references Jira Issue OCPBUGS-29774, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
For historical reasons, "include.release.openshift.io/ibm-cloud-managed" was used as a basis when creating the productized HyperShift installation profile. ibm-cloud-managed is a different offering, however, and we would like to correct this so that (1) the profiles can diverge if necessary and (2) the cluster profile name makes sense. This change establishes a "HypershiftIndependent" profile using the improved profile annotation name "include.release.openshift.io/hypershift" . Dozens of other changes across the product have already been introduced to use this annotation in their manifests - openshift/api needs to support it now. Once this change has merged, "include.release.openshift.io/hypershift" can be tested. We will be able to find any overlooked manifests and annotate them. Once the HyperShift team believes the new annotation can be treated as canonical, we can eliminate ClusterProfileName("include.release.openshift.io/ibm-cloud-managed") and replace it with ClusterProfileName("include.release.openshift.io/hypershift").
Hello @jupierce! Some important instructions when contributing to openshift/api: |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jupierce The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6a7b9e8
to
c01b540
Compare
/retest |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Is the annotation used at all by ROKS? Is eliminating this actually a good idea? |
@jupierce: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
For historical reasons, "include.release.openshift.io/ibm-cloud-managed" was used
as a basis when creating the productized HyperShift installation profile. ibm-cloud-managed
is a different offering, however, and we would like to correct this so that
(1) the profiles can diverge if necessary and (2) the cluster profile name makes
sense.
This change establishes a "HypershiftIndependent" profile using the improved
profile annotation name "include.release.openshift.io/hypershift" . Dozens of
other changes across the product have already been introduced to use this
annotation in their manifests - openshift/api needs to support it now.
Once this change has merged, "include.release.openshift.io/hypershift" can
be tested. We will be able to find any overlooked manifests and annotate them.
Once the HyperShift team believes the new annotation can be treated as
canonical, we can eliminate ClusterProfileName("include.release.openshift.io/ibm-cloud-managed")
and replace it with ClusterProfileName("include.release.openshift.io/hypershift").