Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-29774: Add Intermediate HyperShiftIndependent Profile #1900

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jupierce
Copy link
Contributor

@jupierce jupierce commented May 20, 2024

For historical reasons, "include.release.openshift.io/ibm-cloud-managed" was used
as a basis when creating the productized HyperShift installation profile. ibm-cloud-managed
is a different offering, however, and we would like to correct this so that
(1) the profiles can diverge if necessary and (2) the cluster profile name makes
sense.
This change establishes a "HypershiftIndependent" profile using the improved
profile annotation name "include.release.openshift.io/hypershift" . Dozens of
other changes across the product have already been introduced to use this
annotation in their manifests - openshift/api needs to support it now.
Once this change has merged, "include.release.openshift.io/hypershift" can
be tested. We will be able to find any overlooked manifests and annotate them.
Once the HyperShift team believes the new annotation can be treated as
canonical, we can eliminate ClusterProfileName("include.release.openshift.io/ibm-cloud-managed")
and replace it with ClusterProfileName("include.release.openshift.io/hypershift").

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 20, 2024
@openshift-ci-robot
Copy link

@jupierce: This pull request references Jira Issue OCPBUGS-29774, which is invalid:

  • expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

For historical reasons, "include.release.openshift.io/ibm-cloud-managed" was used as a basis when creating the productized HyperShift installation profile. ibm-cloud-managed is a different offering, however, and we would like to correct this so that (1) the profiles can diverge if necessary and (2) the cluster profile name makes sense.
This change establishes a "HypershiftIndependent" profile using the improved profile annotation name "include.release.openshift.io/hypershift" . Dozens of other changes across the product have already been introduced to use this annotation in their manifests - openshift/api needs to support it now.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 20, 2024
For historical reasons, "include.release.openshift.io/ibm-cloud-managed" was used
as a basis when creating the productized HyperShift installation profile. ibm-cloud-managed
is a different offering, however, and we would like to correct this so that
(1) the profiles can diverge if necessary and (2) the cluster profile name makes
sense.
This change establishes a "HypershiftIndependent" profile using the improved
profile annotation name "include.release.openshift.io/hypershift" . Dozens of
other changes across the product have already been introduced to use this
annotation in their manifests - openshift/api needs to support it now.
Once this change has merged, "include.release.openshift.io/hypershift" can
be tested. We will be able to find any overlooked manifests and annotate them.
Once the HyperShift team believes the new annotation can be treated as
canonical, we can eliminate ClusterProfileName("include.release.openshift.io/ibm-cloud-managed")
and replace it with ClusterProfileName("include.release.openshift.io/hypershift").
Copy link
Contributor

openshift-ci bot commented May 20, 2024

Hello @jupierce! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 20, 2024
@openshift-ci openshift-ci bot requested review from abhat and bparees May 20, 2024 21:16
Copy link
Contributor

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jupierce
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jupierce
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JoelSpeed
Copy link
Contributor

we can eliminate ClusterProfileName("include.release.openshift.io/ibm-cloud-managed")

Is the annotation used at all by ROKS? Is eliminating this actually a good idea?

Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

@jupierce: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify c01b540 link true /test verify
ci/prow/e2e-aws-serial c01b540 link true /test e2e-aws-serial
ci/prow/e2e-aws-serial-techpreview c01b540 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-upgrade c01b540 link true /test e2e-upgrade
ci/prow/e2e-aws-ovn c01b540 link true /test e2e-aws-ovn
ci/prow/e2e-upgrade-minor c01b540 link true /test e2e-upgrade-minor
ci/prow/e2e-aws-ovn-hypershift c01b540 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn-techpreview c01b540 link true /test e2e-aws-ovn-techpreview
ci/prow/minor-e2e-upgrade-minor c01b540 link true /test minor-e2e-upgrade-minor
ci/prow/minor-images c01b540 link true /test minor-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants