Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CAPI install platforms to default feature set #1892

Merged
merged 1 commit into from
May 17, 2024
Merged

Move CAPI install platforms to default feature set #1892

merged 1 commit into from
May 17, 2024

Conversation

patrickdillon
Copy link
Contributor

Moves AWS, Nutanix, OpenStack & vSphere capi installs to default feature set.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 15, 2024

Hello @patrickdillon! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 15, 2024
@openshift-ci openshift-ci bot requested review from deads2k and sjenning May 15, 2024 16:07
@patrickdillon patrickdillon mentioned this pull request May 15, 2024
Merged
@patrickdillon
Copy link
Contributor Author

/test verify

Reading the logs I can't tell what the error is! Not sure if this is a flake/fluke

@patrickdillon
Copy link
Contributor Author

verify tests are failing due to lack of testing, but this test does not seem to take into account platform-specific feature gates cc @deads2k:

error: only 0 tests found, need at least 5 for "ClusterAPIInstallAWS" on {aws amd64 hypershift}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallAWS" on {aws amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallAWS" on {azure amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallAWS" on {gcp amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallNutanix" on {azure amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallNutanix" on {gcp amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallNutanix" on {vsphere-ipi amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallNutanix" on {aws amd64 hypershift}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallNutanix" on {aws amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallOpenStack" on {aws amd64 hypershift}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallOpenStack" on {aws amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallOpenStack" on {azure amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallOpenStack" on {gcp amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallOpenStack" on {vsphere-ipi amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallVSphere" on {aws amd64 hypershift}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallVSphere" on {aws amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallVSphere" on {azure amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallVSphere" on {gcp amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallVSphere" on {vsphere-ipi amd64 ha} error: only 0 tests found, need at least 5 for "ClusterAPIInstallAWS" on {aws amd64 hypershift}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallAWS" on {aws amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallAWS" on {azure amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallAWS" on {gcp amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallNutanix" on {azure amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallNutanix" on {gcp amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallNutanix" on {vsphere-ipi amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallNutanix" on {aws amd64 hypershift}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallNutanix" on {aws amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallOpenStack" on {aws amd64 hypershift}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallOpenStack" on {aws amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallOpenStack" on {azure amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallOpenStack" on {gcp amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallOpenStack" on {vsphere-ipi amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallVSphere" on {aws amd64 hypershift}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallVSphere" on {aws amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallVSphere" on {azure amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallVSphere" on {gcp amd64 ha}
error: only 0 tests found, need at least 5 for "ClusterAPIInstallVSphere" on {vsphere-ipi amd64 ha}

that is, for example, it is expecting a test for the vsphere feature gate on azure:

error: only 0 tests found, need at least 5 for "ClusterAPIInstallVSphere" on {azure amd64 ha}

We have quite a bit of testing for each platform being promoted here:
aws
nutanix
openstack
vsphere

@JoelSpeed
Copy link
Contributor

Based on the linked sippy dashboards above, it appears that the installation success rate of these platforms is good, and that the features being promoted to default here are not negatively affecting installs.

/override ci/prow/verify
/lgtm

/hold In slack there is conversation about some nightly blocking payload commands on an installer PR as a pre-requisite to this, have we got that?

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2024
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify

In response to this:

Based on the linked sippy dashboards above, it appears that the installation success rate of these platforms is good, and that the features being promoted to default here are not negatively affecting installs.

/override ci/prow/verify
/lgtm

/hold In slack there is conversation about some nightly blocking payload commands on an installer PR as a pre-requisite to this, have we got that?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@patrickdillon
Copy link
Contributor Author

/hold In slack there is conversation about some nightly blocking payload commands on an installer PR as a pre-requisite to this, have we got that?

yes openshift/installer#8416 (comment)

@stbenjam stbenjam mentioned this pull request May 16, 2024
Merged
@stbenjam
Copy link
Member

stbenjam commented May 16, 2024 •
edited
Loading

#1895 has an example of how we might test platform and install-specific feature gates, but I'll leave that for Monday for @deads2k to look at.

But TRT is sufficiently satisfied these gates were tested properly, and the overrides are appropriate. The payload blocking platforms are passing.

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, patrickdillon, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoelSpeed
Copy link
Contributor

/hold cancel
/label acknowledge-critical-fixes-only

Welcome to the product Cluster API 🫡

@openshift-ci openshift-ci bot added acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 16, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a20192e and 2 for PR HEAD 6d0fcb1 in total

@patrickdillon
Copy link
Contributor Author

/skip

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1dea023 and 1 for PR HEAD 6d0fcb1 in total

@JoelSpeed
Copy link
Contributor

/override ci/prow/e2e-aws-ovn-hypershift

These gates do not affect HyperShift, they are limited to the openshift-install and the standalone topology

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn-hypershift

In response to this:

/override ci/prow/e2e-aws-ovn-hypershift

These gates do not affect HyperShift, they are limited to the openshift-install and the standalone topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JoelSpeed
Copy link
Contributor

/override ci/prow/verify

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify

In response to this:

/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JoelSpeed
Copy link
Contributor

/retest-required

@JoelSpeed
Copy link
Contributor

/override ci/prow/e2e-aws-ovn-hypershift

These gates do not affect HyperShift, they are limited to the openshift-install and the standalone topology

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn-hypershift

In response to this:

/override ci/prow/e2e-aws-ovn-hypershift

These gates do not affect HyperShift, they are limited to the openshift-install and the standalone topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JoelSpeed
Copy link
Contributor

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 17, 2024

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 931fa98 into openshift:master May 17, 2024
18 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.17.0-202405162013.p0.g931fa98.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

neisw added a commit to neisw/api that referenced this pull request May 20, 2024
@neisw
Revert "Merge pull request openshift#1892 from patrickdillon/capi-ga"
1d20cb1 
This reverts commit 931fa98, reversing
changes made to 1dea023.
@neisw neisw mentioned this pull request May 20, 2024
Closed
@r4f4 r4f4 mentioned this pull request Jun 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@stbenjam stbenjam

@JoelSpeed JoelSpeed

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrickdillon @JoelSpeed @stbenjam @openshift-ci-robot @openshift-bot