SDN-4600: Add NetworkDiagnosticsConfig to the default featureset

[kyrtapz]

Enhancement: openshift/enhancements#1585
E2E tests: openshift/origin#28719

[openshift-ci-robot]

@kyrtapz: This pull request references SDN-4600 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Enhancement: openshift/enhancements#1585
E2E tests: openshift/origin#28719

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[kyrtapz]

/cc @huiran0826

[openshift-ci]

Hello @kyrtapz! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[kyrtapz]

/test e2e-aws-serial

[kyrtapz]

/test e2e-aws-serial
/test e2e-aws-serial-techpreview

[huiran0826]

LGTM

[huiran0826]

/label qe-approved

[openshift-ci-robot]

@kyrtapz: This pull request references SDN-4600 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Enhancement: openshift/enhancements#1585
E2E tests: openshift/origin#28719

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[kyrtapz]

/test e2e-aws-serial-techpreview

[kyrtapz]

/retest

[trozet]

/lgtm

[JoelSpeed]

Looking at the verify-schema, we should probably update the list tags that are missing

error in config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_networks.crd.yaml: ListsMustHaveSSATags: crd/networks.config.openshift.io version/v1 field/^.status.serviceNetwork must set x-kubernetes-list-type
		error in config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_networks.crd.yaml: ListsMustHaveSSATags: crd/networks.config.openshift.io version/v1 field/^.status.clusterNetwork must set x-kubernetes-list-type

I would assume both of these can just be set to atomic since the only actor on status fields should be the operator right?

// +listType=atomic

Otherwise as far as I can tell this looks good to go, you have tests (which look green, you have QE sign off, all generation appears to be up to date

[kyrtapz]

Looking at the verify-schema, we should probably update the list tags that are missing

error in config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_networks.crd.yaml: ListsMustHaveSSATags: crd/networks.config.openshift.io version/v1 field/^.status.serviceNetwork must set x-kubernetes-list-type
		error in config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_networks.crd.yaml: ListsMustHaveSSATags: crd/networks.config.openshift.io version/v1 field/^.status.clusterNetwork must set x-kubernetes-list-type

I would assume both of these can just be set to atomic since the only actor on status fields should be the operator right?

// +listType=atomic

Sounds good, I can look into it. Since this is an unrelated change I would like to keep it separate from this PR.

[JoelSpeed]

/lgtm
/override ci/prow/verify-crd-schema
/override ci/prow/verify

We have a follow up to fix the SSA tags, and the verify is complaining of missing E2E but we have that linked here and QE approval

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify, ci/prow/verify-crd-schema

In response to this:

/lgtm
/override ci/prow/verify-crd-schema
/override ci/prow/verify

We have a follow up to fix the SSA tags, and the verify is complaining of missing E2E but we have that linked here and QE approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kyrtapz]

/label acknowledge-critical-fixes-only

[kyrtapz]

Had to rebase to resolve conflicts in the auto-generated files.
@JoelSpeed ptal

[JoelSpeed]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, kyrtapz, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 14ae5de and 2 for PR HEAD 0385715 in total

[JoelSpeed]

/override ci/prow/verify-crd-schema
/override ci/prow/verify

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify, ci/prow/verify-crd-schema

In response to this:

/override ci/prow/verify-crd-schema
/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@kyrtapz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.17.0-202405151441.p0.g0f9dbca.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.