-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "Merge pull request #1851 from slashpai/metrics-server"" #1865
Conversation
Hello @slashpai! Some important instructions when contributing to openshift/api: |
ad33656
to
1b2247f
Compare
Once openshift/cluster-monitoring-operator#2329 is merged will verify the payload jobs as mentioned in #1863 |
@jan--f: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2329
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d8dbc4d0-0169-11ef-80b3-937f07d81a34-0 |
@slashpai: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2329
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/346f42d0-016b-11ef-9c35-974f633a4f3f-0 |
@slashpai: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2329
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e5caf660-0214-11ef-8541-c562082f3eaa-0 |
@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9dbc6850-0259-11ef-9e43-91a4f4b17de5-0 |
@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e77c90a0-0259-11ef-92b5-46f4e3c5ea9b-0 |
@slashpai: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2329
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f972a990-02a7-11ef-85c8-8a3d6e2fa727-0 |
@slashpai: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2329
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/aaa566b0-02b4-11ef-86e4-14f7e6cef418-0 |
@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/08763970-02d5-11ef-82c2-1f947f29a0f2-0 |
@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1e127370-02d5-11ef-97af-1d2088b40c8e-0 |
@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7f533b40-02d7-11ef-8c02-887ff64c5f91-0 |
@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/952ccc60-02d7-11ef-812b-00c219e3f7ee-0 |
@machine424: This PR was included in a payload test run from openshift/origin#28737
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ce85df90-02de-11ef-8c62-2e3db784f5f9-0 |
@machine424: This PR was included in a payload test run from openshift/origin#28737 |
@machine424: This PR was included in a payload test run from openshift/origin#28737
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/77395d40-02e1-11ef-97dd-2274b69c7a75-0 |
@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0bcb3d90-02e5-11ef-88cf-4f39eb501bae-0 |
@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e54431c0-02e6-11ef-8f89-cc5fc554685e-0 |
@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5d951ca0-02ee-11ef-9a17-e1aef94cff96-0 |
@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2329
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b85820b0-02ee-11ef-8b3a-9bacb4e24e64-0 |
@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8a9d9a10-030c-11ef-99a4-cc9de0e1dc97-0 |
@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5d2c8c70-0312-11ef-98a4-0fcb178406dc-0 |
@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4bbc5370-0313-11ef-9250-ffcbefb52abe-0 |
@slashpai: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2337
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5a5eb190-1117-11ef-93e5-df91624bf14d-0 |
/retest |
1 similar comment
/retest |
/payload-job periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance |
@slashpai: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d1304c00-11b9-11ef-8234-e716ff5658d4-0 |
/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node |
@slashpai: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ea8d85a0-11b9-11ef-98f4-6bab88c48b85-0 |
/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node |
@slashpai: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bb7bcb10-11e5-11ef-9bc7-9e0691688c9a-0 |
/lgtm |
QE already signed off on this, TRT reverted and requested HyperShift conformance on the un-revert, can see that's green here so happy to continue /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, simonpasquier, slashpai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold cancel |
/label qe-approved |
/payload 4.16 nightly blocking |
@slashpai: trigger 8 job(s) of type blocking for the nightly release of OCP 4.16
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/65cf6820-1280-11ef-9184-7fd52980e1ee-0 |
We already tested hypershift and sno payload test which were failing in previous attempt before fix hypershift: #1865 (comment) /label acknowledge-critical-fixes-only |
@slashpai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fix is added in openshift/cluster-monitoring-operator#2334
SNO fix in openshift/cluster-monitoring-operator#2337
This reverts commit a7a9d56.
Adding placeholder to add back the feature gate to default and testing payload jobs before merging
/hold
cc: @machine424 @jan--f