-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose chunksize variable for S3 storage driver #1864
Expose chunksize variable for S3 storage driver #1864
Conversation
Skipping CI for Draft Pull Request. |
Hello @deepsm007! Some important instructions when contributing to openshift/api: |
/test all |
left a comment. this looks good for a registry perspective otherwise. |
5dcce6b
to
4e862cc
Compare
e5adb0f
to
d8b5d7b
Compare
d8b5d7b
to
8bef434
Compare
/assign @JoelSpeed |
e351ff9
to
e74c2b7
Compare
Verify failures are because we cannot detect that you are duplicating the CRD that already exists, however, we do want you to fix The tests are genuinely broken, you are not using the correct casing for you field which means it's being dropped, please fix the casing |
e74c2b7
to
32672aa
Compare
32672aa
to
26f4723
Compare
/test verify |
PR needs rebase and the verify-crd-schema job is still broken. |
26f4723
to
62065c7
Compare
/lgtm Failures in the CRD schema check are pre-existing and from corev1 types that cannot be fixed |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepsm007, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
/test e2e-aws-serial-techpreview |
Failures in the CRD schema check are pre-existing and from corev1 types that cannot be fixed |
@deads2k: Overrode contexts on behalf of deads2k: ci/prow/verify-crd-schema In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@deepsm007: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
0a2abb2
into
openshift:master
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-config-api-container-v4.17.0-202405040320.p0.g0a2abb2.assembly.stream.el9 for distgit ose-cluster-config-api. |
Expose chunksize variable for S3 storage driver
openshift/cluster-image-registry-operator#1026
/hold