Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: generate insightsdatagatherers when InsightsConfigAPI is enabled #1857

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

NO-JIRA: generate insightsdatagatherers when InsightsConfigAPI is enabled #1857

wants to merge 2 commits into from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 12, 2024

When I was converting to gates I didn't notice InsightsConfigAPI. If it's appropriate, I'd like to gate the InsightsDataGathers on the previously existing InsightsConfigAPI instead of the new InsightsConfig I added. Is that appropriate?

/assign @tremes

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

Hello @deads2k! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 12, 2024
@openshift-ci openshift-ci bot requested review from bparees and JoelSpeed April 12, 2024 17:24
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2024
@tremes
Copy link
Contributor

tremes commented Apr 22, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k deads2k force-pushed the by-gate-38-scrub-old-3 branch from 4b3dfa1 to b4a1b44 Compare April 25, 2024 14:32
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

New changes are detected. LGTM label has been removed.

@deads2k deads2k changed the title generate insightsdatagatherers when InsightsConfigAPI is enabled NO-JIRA: generate insightsdatagatherers when InsightsConfigAPI is enabled Apr 25, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 25, 2024
@openshift-ci-robot
Copy link

@deads2k: This pull request explicitly references no jira issue.

In response to this:

When I was converting to gates I didn't notice InsightsConfigAPI. If it's appropriate, I'd like to gate the InsightsDataGathers on the previously existing InsightsConfigAPI instead of the new InsightsConfig I added. Is that appropriate?

/assign @tremes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. and removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Apr 25, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Apr 25, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8203151 and 2 for PR HEAD b4a1b44 in total

@deads2k
Copy link
Contributor Author

deads2k commented Apr 25, 2024

/retest

2 similar comments
@deads2k
Copy link
Contributor Author

deads2k commented Apr 26, 2024

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Apr 26, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ac9356b and 1 for PR HEAD b4a1b44 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fe20d81 and 0 for PR HEAD b4a1b44 in total

@openshift-ci-robot
Copy link

/hold

Revision b4a1b44 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 28, 2024

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/verify-crd-schema

In response to this:

/override ci/prow/verify-crd-schema
/hold cancel
/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@deads2k
Copy link
Contributor Author

deads2k commented May 28, 2024

/override ci/prow/verify-crd-schema

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 28, 2024

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/verify-crd-schema

In response to this:

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ba11c15 and 2 for PR HEAD b4a1b44 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 16d44e6 and 1 for PR HEAD b4a1b44 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b01900f and 0 for PR HEAD b4a1b44 in total

@openshift-ci-robot
Copy link

/hold

Revision b4a1b44 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2024
@tremes
Copy link
Contributor

tremes commented Jun 24, 2024

/unhold
/test e2e-aws-serial-techpreview

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2024
@JoelSpeed
Copy link
Contributor

Re-overriding since the override got cleared

/override ci/prow/verify-crd-schema

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to this:

Re-overriding since the override got cleared

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 987b889 and 2 for PR HEAD b4a1b44 in total

@tremes
Copy link
Contributor

tremes commented Jun 25, 2024

/test e2e-upgrade-minor

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0689f00 and 1 for PR HEAD b4a1b44 in total

@JoelSpeed
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d3b3bb1 and 0 for PR HEAD b4a1b44 in total

@JoelSpeed
Copy link
Contributor

/hold

The upgrade minor job is presently broken, but I'd like to see this pass through that before merging.

Can unhold once openshift/release#53843 is merged

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Jul 8, 2024

/test all

@deads2k
Copy link
Contributor Author

deads2k commented Jul 9, 2024

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 14, 2024
@tremes
Copy link
Contributor

tremes commented Nov 14, 2024

I think we still want to merge this one right? Can you please rebase @deads2k?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-crd-schema b4a1b44 link true /test verify-crd-schema
ci/prow/e2e-aws-serial b4a1b44 link true /test e2e-aws-serial
ci/prow/e2e-upgrade b4a1b44 link true /test e2e-upgrade
ci/prow/e2e-aws-ovn-techpreview b4a1b44 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn-hypershift b4a1b44 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-upgrade-minor b4a1b44 link true /test e2e-upgrade-minor
ci/prow/e2e-aws-ovn b4a1b44 link true /test e2e-aws-ovn
ci/prow/e2e-aws-serial-techpreview b4a1b44 link true /test e2e-aws-serial-techpreview
ci/prow/minor-images b4a1b44 link true /test minor-images
ci/prow/minor-e2e-upgrade-minor b4a1b44 link true /test minor-e2e-upgrade-minor
ci/prow/lint b4a1b44 link true /test lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deads2k @tremes @openshift-ci-robot @JoelSpeed @openshift-merge-robot @openshift-bot