ETCD-520: add etcd dbsize field #1736

Elbehery · 2024-01-21T16:01:32Z

This PR adds field etcdDBSize to etcd-operator CRD to make etcd backend storage size configurable in OCP.

resolves https://issues.redhat.com/browse/ETCD-513

cc @soltysh @deads2k @tjungblu @dusk125 @hasbro17

openshift-ci-robot · 2024-01-21T16:01:35Z

@Elbehery: This pull request references ETCD-513 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

This PR adds field etcdDBSize to etcd-operator CRD to make etcd backend storage size configurable in OCP.

resolves https://issues.redhat.com/browse/ETCD-513

cc @soltysh @deads2k @tjungblu @dusk125 @hasbro17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Elbehery · 2024-01-21T16:01:37Z

/hold

openshift-ci · 2024-01-21T16:01:38Z

Hello @Elbehery! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci-robot · 2024-01-21T19:48:08Z

@Elbehery: This pull request references ETCD-520 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR adds field etcdDBSize to etcd-operator CRD to make etcd backend storage size configurable in OCP.

resolves https://issues.redhat.com/browse/ETCD-513

cc @soltysh @deads2k @tjungblu @dusk125 @hasbro17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

operator/v1/types_etcd.go

Elbehery · 2024-01-22T17:55:56Z

/assign @deads2k
/assign @soltysh

Elbehery · 2024-01-22T17:56:14Z

/retest-required

Elbehery · 2024-01-22T18:36:52Z

/retest-required

Elbehery · 2024-01-23T14:02:05Z

the failure in ci/prow/integration is due to other tests

cc @soltysh

dusk125 · 2024-01-24T16:09:57Z

Enhancement for this change can be found here openshift/enhancements#1549

operator/v1/types_etcd.go

Elbehery · 2024-04-25T22:09:11Z

/retest-required

Elbehery · 2024-04-26T05:56:33Z

/test e2e-aws-ovn-hypershift

Elbehery · 2024-04-26T06:08:01Z

see thread for hypershift job failure

Elbehery · 2024-04-26T07:23:46Z

@soltysh e2e-aws-ovn-hypershift fails due to this

Shall we override ?

JoelSpeed · 2024-04-26T08:31:32Z

openapi/openapi.json

+          "description": "backendQuotaGiB sets the etcd backend storage size limit in gibibytes. The value should be an integer not less than 8 and not more than 32. When not specified, the default value is 8.",
+          "type": "integer",
+          "format": "int32",
+          "default": 0


That's not right, this should be 8, whys the tag not worked 🤔

I have no idea why .. the taga are correct

operator/v1/types_etcd.go

JoelSpeed · 2024-04-29T14:28:49Z

example/v1/types_stable.go

+	// backendQuotaGiB sets the etcd backend storage size limit in gibibytes.
+	// The value should be an integer not less than 8 and not more than 32.
+	// When not specified, the default value is 8.
+	// +kubebuilder:default:=8
+	// +kubebuilder:validation:Minimum=8
+	// +kubebuilder:validation:Maximum=32
+	// +kubebuilder:validation:XValidation:rule="self>=oldSelf",message="etcd backendQuotaGiB may not be decreased"
+	// +openshift:enable:FeatureGate=EtcdBackendQuota
+	// +default:=8
+	// +optional
+	BackendQuotaGiB int32 `json:"backendQuotaGiB,omitempty"`


Lets do the example as a separate PR, and please make it generic, we are looking to show a specific thing here which is the defaulting and min/max, we don't need the full type. See other examples and how they're set up

Elbehery · 2024-04-29T16:56:42Z

/retest-required

Elbehery · 2024-04-29T18:18:16Z

/retest-required

operator/v1/types_etcd.go

JoelSpeed · 2024-05-02T18:47:14Z

I'm happy with the content of the PR at this point, is the rest of this feature ready to go, is the plan still to try and merge this for 4.16?

Elbehery · 2024-05-02T19:55:03Z

I'm happy with the content of the PR at this point, is the rest of this feature ready to go, is the plan still to try and merge this for 4.16?

yes it is due on 4.16

the rest of this feature is here already done waiting on this to merge .. i already tested manually on a cluster and it is working .. you can find the e2e test on this PR at this file test/e2e/scaling_dbsize_test.go

Once this PR merge, I will bump the openshift/api dep and remove the manual steps on the e2e test

cc @soltysh @openshift/openshift-team-etcd cc @dmwest2

Elbehery · 2024-05-02T20:35:18Z

/retest-required

JoelSpeed · 2024-05-03T07:38:20Z

/approve

Can someone from the team working this feature, @soltysh maybe, add the LGTM and hold cancel if we are happy for this to merge at this point, considering proximity to the feature freeze

Elbehery · 2024-05-03T08:44:50Z

/approve

Can someone from the team working this feature, @soltysh maybe, add the LGTM and hold cancel if we are happy for this to merge at this point, considering proximity to the feature freeze

@soltysh is on vacation, maybe @deads2k or @mfojtik can label it ?

cc @openshift/openshift-team-etcd

Elbehery · 2024-05-03T08:45:17Z

/hold cancel

deads2k · 2024-05-03T13:28:40Z

before going to accessible-by-default, in addition to tests the API PR must link tested documentation for

Etcd Team to investigate whether a larger etcd database can cause crash-loops in Etcd (via out-of-memory for example) on restarts (similar to the above API server issue).
- If it is possible to get into a crash-loop because of the database size, the Etcd team will document how to recover the Etcd cluster from this state.

and if it is "impossible", I'd like to understand where the infinite memory machine comes from.

deads2k · 2024-05-03T13:28:47Z

/lgtm

openshift-ci · 2024-05-03T13:29:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, Elbehery, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed,deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2024-05-03T16:58:36Z

@Elbehery: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2024-05-03T20:52:39Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.16.0-202405031950.p0.g56da039.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 21, 2024

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2024

openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2024

openshift-ci bot requested review from knobunc and mfojtik January 21, 2024 16:02

Elbehery mentioned this pull request Jan 21, 2024

WIP:ETCD-519:Add reconcile etcd database size openshift/cluster-etcd-operator#1184

Closed

Elbehery changed the title ~~WIP:ETCD-513: add etcd dbsize field~~ WIP:ETCD-520: add etcd dbsize field Jan 21, 2024

hasbro17 reviewed Jan 21, 2024

View reviewed changes

operator/v1/types_etcd.go Outdated Show resolved Hide resolved

Elbehery force-pushed the add_etcd_database_size branch 2 times, most recently from b66c470 to 3d08345 Compare January 22, 2024 16:41

openshift-ci bot assigned deads2k and soltysh Jan 22, 2024

Elbehery force-pushed the add_etcd_database_size branch from 3d08345 to 06a94e1 Compare January 23, 2024 13:24

hasbro17 mentioned this pull request Jan 31, 2024

ETCD-514: Add etcd size tuning openshift/enhancements#1549

Merged

Elbehery force-pushed the add_etcd_database_size branch from 06a94e1 to cfc0028 Compare January 31, 2024 21:35

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2024

Elbehery commented Jan 31, 2024

View reviewed changes

operator/v1/types_etcd.go Outdated Show resolved Hide resolved

Elbehery force-pushed the add_etcd_database_size branch from cfc0028 to 7438bd6 Compare March 14, 2024 21:43

openshift-ci bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 14, 2024

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2024

JoelSpeed reviewed Apr 26, 2024

View reviewed changes

Elbehery force-pushed the add_etcd_database_size branch from 348fa41 to b9b2750 Compare April 29, 2024 14:12

JoelSpeed reviewed Apr 29, 2024

View reviewed changes

Elbehery force-pushed the add_etcd_database_size branch from b9b2750 to 24eb9f0 Compare April 29, 2024 14:34

Elbehery mentioned this pull request Apr 29, 2024

ETCD-520: add BackendQuotaGiB example #1874

Merged

Elbehery force-pushed the add_etcd_database_size branch from 24eb9f0 to fc5c9de Compare April 29, 2024 15:09

JoelSpeed reviewed May 2, 2024

View reviewed changes

operator/v1/types_etcd.go Outdated Show resolved Hide resolved

ETCD-520: add etcd BackendQuotaGiB field

86b054e

Elbehery force-pushed the add_etcd_database_size branch from fc5c9de to 86b054e Compare May 2, 2024 17:33

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2024

openshift-merge-bot bot merged commit 56da039 into openshift:master May 3, 2024
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ETCD-520: add etcd dbsize field #1736

ETCD-520: add etcd dbsize field #1736

Elbehery commented Jan 21, 2024

openshift-ci-robot commented Jan 21, 2024 •

edited by openshift-ci bot

Loading

Elbehery commented Jan 21, 2024

openshift-ci bot commented Jan 21, 2024

openshift-ci-robot commented Jan 21, 2024 •

edited by openshift-ci bot

Loading

Elbehery commented Jan 22, 2024

Elbehery commented Jan 22, 2024

Elbehery commented Jan 22, 2024

Elbehery commented Jan 23, 2024

dusk125 commented Jan 24, 2024

Elbehery commented Apr 25, 2024

Elbehery commented Apr 26, 2024

Elbehery commented Apr 26, 2024

Elbehery commented Apr 26, 2024

JoelSpeed Apr 26, 2024

Elbehery Apr 26, 2024

JoelSpeed Apr 29, 2024

Elbehery commented Apr 29, 2024

Elbehery commented Apr 29, 2024

JoelSpeed commented May 2, 2024

Elbehery commented May 2, 2024 •

edited

Loading

Elbehery commented May 2, 2024

JoelSpeed commented May 3, 2024

Elbehery commented May 3, 2024

Elbehery commented May 3, 2024

deads2k commented May 3, 2024

deads2k commented May 3, 2024

openshift-ci bot commented May 3, 2024

openshift-ci bot commented May 3, 2024

openshift-bot commented May 3, 2024

ETCD-520: add etcd dbsize field #1736

ETCD-520: add etcd dbsize field #1736

Conversation

Elbehery commented Jan 21, 2024

openshift-ci-robot commented Jan 21, 2024 • edited by openshift-ci bot Loading

Elbehery commented Jan 21, 2024

openshift-ci bot commented Jan 21, 2024

openshift-ci-robot commented Jan 21, 2024 • edited by openshift-ci bot Loading

Elbehery commented Jan 22, 2024

Elbehery commented Jan 22, 2024

Elbehery commented Jan 22, 2024

Elbehery commented Jan 23, 2024

dusk125 commented Jan 24, 2024

Elbehery commented Apr 25, 2024

Elbehery commented Apr 26, 2024

Elbehery commented Apr 26, 2024

Elbehery commented Apr 26, 2024

JoelSpeed Apr 26, 2024

Choose a reason for hiding this comment

Elbehery Apr 26, 2024

Choose a reason for hiding this comment

JoelSpeed Apr 29, 2024

Choose a reason for hiding this comment

Elbehery commented Apr 29, 2024

Elbehery commented Apr 29, 2024

JoelSpeed commented May 2, 2024

Elbehery commented May 2, 2024 • edited Loading

Elbehery commented May 2, 2024

JoelSpeed commented May 3, 2024

Elbehery commented May 3, 2024

Elbehery commented May 3, 2024

deads2k commented May 3, 2024

deads2k commented May 3, 2024

openshift-ci bot commented May 3, 2024

openshift-ci bot commented May 3, 2024

openshift-bot commented May 3, 2024

openshift-ci-robot commented Jan 21, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jan 21, 2024 •

edited by openshift-ci bot

Loading

Elbehery commented May 2, 2024 •

edited

Loading