-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MON-3410: Add FeatureGate for MetricsServer #1615
Conversation
@slashpai: This pull request references MON-3410 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hello @slashpai! Some important instructions when contributing to openshift/api: |
@simonpasquier PTAL |
fc8492e
to
ba1e67a
Compare
/assign @simonpasquier |
/lgtm |
ba1e67a
to
0a696c1
Compare
0a696c1
to
e744ac3
Compare
rebased |
/lgtm |
@deads2k Could you please review? |
enhancement proposal: openshift/enhancements#1426 Signed-off-by: Jayapriya Pai <janantha@redhat.com>
e744ac3
to
bc00352
Compare
/retest |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, simonpasquier, slashpai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@slashpai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
enhancement proposal: openshift/enhancements#1426
This feature will TechPreview in OCP 4.15 hence adding a feature gate where the feature is to be enabled only on TechPreview Clusters and not in standard cluster.
Goal is to disable the feature by default in 4.15 but enable it only in TechPreviewNoUpgrade clusters
cc: @simonpasquier