Bug 2049838: added Nutanix platform to openshift/api #1059
Conversation
|
Hi @yannickstruyf3. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-ok-to-test
| @@ -169,6 +169,9 @@ const ( | |||
|
|
|||
| // AlibabaCloudPlatformType represents Alibaba Cloud infrastructure. | |||
| AlibabaCloudPlatformType PlatformType = "AlibabaCloud" | |||
|
|
|||
| // NutanixPlatformType represents Nutanix infrastructure. | |||
| NutanixPlatformType PlatformType = "Nutanix" | |||
There was a problem hiding this comment.
This value needs to be added to the +kubebuilder:validation:Enum annotation on the PlatformType type.
There was a problem hiding this comment.
@staebler Added the value as requested.
…n on the PlatformType type
|
@sttts These changes look good to me. The Nutanix platform is coming in 4.11. Would you prefer holding off on merging this until we open for 4.11? Or is it OK to get this in now to make it easier for putting together and testing other work that depends on these changes? |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
@staebler: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a stopgap solution until openshift is able to merge the API PR openshift#1059 openshift/api#1059.
This is a stopgap solution until openshift is able to merge the API PR openshift#1059 openshift/api#1059.
| // by components inside the cluster, like kubelets using the infrastructure rather | ||
| // than Kubernetes networking. It is the IP that the Infrastructure.status.apiServerInternalURI | ||
| // points to. It is the IP for a self-hosted load balancer in front of the API servers. | ||
| APIServerInternalIP string `json:"apiServerInternalIP,omitempty"` |
There was a problem hiding this comment.
why do we need this in addition?
There was a problem hiding this comment.
@sttts Correct me if I'm wrong but AFAIK on-prem platforms are expected to provide both these fields to the machine config operator. see: https://github.com/openshift/machine-config-operator/pull/2852/files#
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rvanderp3, sttts, yannickstruyf3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
LGTM /assign @benluddy @p0lyn0mial |
sdodson
added
the
bugzilla/valid-bug
|
Adding |
|
@yannickstruyf3: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retitle Bug 2049838: added Nutanix platform to openshift/api |
openshift-ci
bot
changed the title
|
@yannickstruyf3: All pull requests linked via external trackers have merged: Bugzilla bug 2049838 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@tkashem: Bugzilla bug 2049838 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds the Nutanix platform to the openshift/api repo.