Bug 1992592: Atomic List Type #1028

EmilyM1 · 2021-10-12T21:04:27Z

Making list atomic to prevent GitOps overwrite

soltysh · 2021-10-13T08:00:39Z

config/v1/types_oauth.go

@@ -31,6 +31,7 @@ type OAuthSpec struct {
 	// identityProviders is an ordered list of ways for a user to identify themselves.
 	// When this list is empty, no identities are provisioned for users.
 	// +optional
+	// listType=atomic


It's a tag, so it should be // +listType=atomic

I totally miss a discussion why atomic is correct here. I doubt it is.

"Making list atomic to prevent GitOps overwrite" – atomic enforces exactly that: overwrite.

soltysh · 2021-10-13T08:01:46Z

/retitle Bug 1992592: Atomic List Type

openshift-ci · 2021-10-13T08:02:52Z

@EmilyM1: This pull request references Bugzilla bug 1992592, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1992592: Atomic List Type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

EmilyM1 · 2021-10-13T21:02:26Z

/bugzilla refresh

openshift-ci · 2021-10-13T21:02:29Z

@EmilyM1: This pull request references Bugzilla bug 1992592, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

EmilyM1 · 2021-10-13T21:07:41Z

/bugzilla refresh

openshift-ci · 2021-10-13T21:07:47Z

@EmilyM1: This pull request references Bugzilla bug 1992592, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (liyao@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh

/lgtm
/approve

openshift-ci · 2021-10-14T06:30:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilyM1, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-10-14T06:31:40Z

@EmilyM1: All pull requests linked via external trackers have merged:

openshift/api#1028

Bugzilla bug 1992592 has been moved to the MODIFIED state.

In response to this:

Bug 1992592: Atomic List Type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

EmilyM1 · 2021-10-18T20:31:37Z

/cherry-pick release-4.9

openshift-cherrypick-robot · 2021-10-18T20:32:19Z

@EmilyM1: new pull request created: #1036

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

EmilyM1 · 2021-10-27T16:42:57Z

/cherry-pick release-4.8

openshift-cherrypick-robot · 2021-10-27T16:43:38Z

@EmilyM1: #1028 failed to apply on top of branch "release-4.8":

Applying: add atomic listType
Using index info to reconstruct a base tree...
M	config/v1/0000_10_config-operator_01_oauth.crd.yaml
M	config/v1/types_oauth.go
Falling back to patching base and 3-way merge...
Auto-merging config/v1/types_oauth.go
Auto-merging config/v1/0000_10_config-operator_01_oauth.crd.yaml
CONFLICT (content): Merge conflict in config/v1/0000_10_config-operator_01_oauth.crd.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add atomic listType
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

EmilyM1 · 2021-11-10T00:29:50Z

/cherry-pick release-4.8

openshift-cherrypick-robot · 2021-11-10T00:30:30Z

@EmilyM1: #1028 failed to apply on top of branch "release-4.8":

Applying: add atomic listType
Using index info to reconstruct a base tree...
M	config/v1/0000_10_config-operator_01_oauth.crd.yaml
M	config/v1/types_oauth.go
Falling back to patching base and 3-way merge...
Auto-merging config/v1/types_oauth.go
Auto-merging config/v1/0000_10_config-operator_01_oauth.crd.yaml
CONFLICT (content): Merge conflict in config/v1/0000_10_config-operator_01_oauth.crd.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add atomic listType
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

EmilyM1 · 2021-12-23T23:41:32Z

/cherry-pick release-4.8

openshift-cherrypick-robot · 2021-12-23T23:42:11Z

@EmilyM1: #1028 failed to apply on top of branch "release-4.8":

Applying: add atomic listType
Using index info to reconstruct a base tree...
M	config/v1/0000_10_config-operator_01_oauth.crd.yaml
M	config/v1/types_oauth.go
Falling back to patching base and 3-way merge...
Auto-merging config/v1/types_oauth.go
Auto-merging config/v1/0000_10_config-operator_01_oauth.crd.yaml
CONFLICT (content): Merge conflict in config/v1/0000_10_config-operator_01_oauth.crd.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add atomic listType
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This is a cherry-pick of openshift#1028 (c7f90e1)

openshift-ci bot requested review from bparees and eparis October 12, 2021 21:04

EmilyM1 changed the title ~~bug 1992592 - Atomic List Type #1027~~ bug 1992592 - Atomic List Type Oct 12, 2021

EmilyM1 force-pushed the atomic-type-bug branch from b773eae to 437a72a Compare October 12, 2021 21:48

soltysh suggested changes Oct 13, 2021

View reviewed changes

openshift-ci bot changed the title ~~bug 1992592 - Atomic List Type~~ Bug 1992592: Atomic List Type Oct 13, 2021

openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Oct 13, 2021

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 13, 2021

EmilyM1 force-pushed the atomic-type-bug branch from 73bb042 to f0f9f74 Compare October 13, 2021 20:19

add atomic listType

4ce104f

EmilyM1 force-pushed the atomic-type-bug branch from f83da6b to 4ce104f Compare October 13, 2021 20:53

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 13, 2021

soltysh approved these changes Oct 14, 2021

View reviewed changes

openshift-ci bot assigned soltysh Oct 14, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2021

openshift-merge-robot merged commit be2a7fb into openshift:master Oct 14, 2021

openshift-ci bot mentioned this pull request Oct 18, 2021

Bug 1992592: bump api openshift/cluster-config-operator#219

Merged

openshift-cherrypick-robot mentioned this pull request Oct 18, 2021

[release-4.9] Bug 2015306: Atomic List Type #1036

Merged

pierreprinetti added a commit to shiftstack/api that referenced this pull request May 2, 2022

Bug 2040407: Make OAuth IdentityProviders list atomic

fd10b78

This is a cherry-pick of openshift#1028 (c7f90e1)

pierreprinetti mentioned this pull request May 2, 2022

Bug 2040407: Make OAuth IdentityProviders list atomic #1189

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1992592: Atomic List Type #1028

Bug 1992592: Atomic List Type #1028

EmilyM1 commented Oct 12, 2021 •

edited

Loading

soltysh Oct 13, 2021

EmilyM1 Oct 13, 2021

sttts Jan 14, 2022

sttts Jan 14, 2022

soltysh commented Oct 13, 2021

openshift-ci bot commented Oct 13, 2021

EmilyM1 commented Oct 13, 2021

openshift-ci bot commented Oct 13, 2021

EmilyM1 commented Oct 13, 2021

openshift-ci bot commented Oct 13, 2021

soltysh left a comment

openshift-ci bot commented Oct 14, 2021

openshift-ci bot commented Oct 14, 2021

EmilyM1 commented Oct 18, 2021

openshift-cherrypick-robot commented Oct 18, 2021

EmilyM1 commented Oct 27, 2021

openshift-cherrypick-robot commented Oct 27, 2021

EmilyM1 commented Nov 10, 2021

openshift-cherrypick-robot commented Nov 10, 2021

EmilyM1 commented Dec 23, 2021

openshift-cherrypick-robot commented Dec 23, 2021

Bug 1992592: Atomic List Type #1028

Bug 1992592: Atomic List Type #1028

Conversation

EmilyM1 commented Oct 12, 2021 • edited Loading

soltysh Oct 13, 2021

Choose a reason for hiding this comment

EmilyM1 Oct 13, 2021

Choose a reason for hiding this comment

sttts Jan 14, 2022

Choose a reason for hiding this comment

sttts Jan 14, 2022

Choose a reason for hiding this comment

soltysh commented Oct 13, 2021

openshift-ci bot commented Oct 13, 2021

EmilyM1 commented Oct 13, 2021

openshift-ci bot commented Oct 13, 2021

EmilyM1 commented Oct 13, 2021

openshift-ci bot commented Oct 13, 2021

soltysh left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Oct 14, 2021

openshift-ci bot commented Oct 14, 2021

EmilyM1 commented Oct 18, 2021

openshift-cherrypick-robot commented Oct 18, 2021

EmilyM1 commented Oct 27, 2021

openshift-cherrypick-robot commented Oct 27, 2021

EmilyM1 commented Nov 10, 2021

openshift-cherrypick-robot commented Nov 10, 2021

EmilyM1 commented Dec 23, 2021

openshift-cherrypick-robot commented Dec 23, 2021

EmilyM1 commented Oct 12, 2021 •

edited

Loading