Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alibaba api #1003

Merged
merged 12 commits into from
Sep 7, 2021
Merged

Alibaba api #1003

merged 12 commits into from
Sep 7, 2021

Conversation

kwoodson
Copy link
Contributor

@kwoodson kwoodson commented Sep 7, 2021

Update to the existing #970 and fixing comments.

Lyt99 and others added 11 commits September 7, 2021 09:10
Signed-off-by: xiayu.lyt <xiayu.lyt@alibaba-inc.com>
Signed-off-by: xiayu.lyt <xiayu.lyt@alibaba-inc.com>
Signed-off-by: xiayu.lyt <xiayu.lyt@alibaba-inc.com>
Signed-off-by: xiayu.lyt <xiayu.lyt@alibaba-inc.com>
Signed-off-by: xiayu.lyt <xiayu.lyt@alibaba-inc.com>
Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>
Signed-off-by: xiayu.lyt <xiayu.lyt@alibaba-inc.com>
Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>
Signed-off-by: xiayu.lyt <xiayu.lyt@alibaba-inc.com>
Signed-off-by: xiayu.lyt <xiayu.lyt@alibaba-inc.com>
@kwoodson
Copy link
Contributor Author

kwoodson commented Sep 7, 2021

@sttts Please TAL. Thanks!

@sttts
Copy link
Contributor

sttts commented Sep 7, 2021

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwoodson, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 7, 2021
@openshift-merge-robot openshift-merge-robot merged commit c9d6fcc into openshift:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants