Skip to content

NO-ISSUE: cluster-update/cluster-update-advisor: Rename to match skill name - #47

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
wking:cluster-update-advisor-directory
Aug 13, 2026
Merged

NO-ISSUE: cluster-update/cluster-update-advisor: Rename to match skill name#47
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
wking:cluster-update-advisor-directory

Conversation

@wking

@wking wking commented Aug 13, 2026

Copy link
Copy Markdown
Member

From the spec for name

Must match the parent directory name

This renames the directory to align with the skill name, because "cluster update" distinguishes us from other things that could be updated (OLM-installed operators, user workload, etc.).

From the spec for 'name' [1]

  Must match the parent directory name

This renames the directory to align with the skill 'name', because
"cluster update" distinguishes us from other things that could be
updated (OLM-installed operators, user workload, etc.).

[1]: https://agentskills.io/specification#name-field
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 13, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@wking: This pull request explicitly references no jira issue.

Details

In response to this:

From the spec for name

Must match the parent directory name

This renames the directory to align with the skill name, because "cluster update" distinguishes us from other things that could be updated (OLM-installed operators, user workload, etc.).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from DavidHurta and fao89 August 13, 2026 22:46
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2026

@mrunalp mrunalp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2026
@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp

mrunalp commented Aug 13, 2026

Copy link
Copy Markdown
Member

/override ci/prow/eval

@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown

@mrunalp: Overrode contexts on behalf of mrunalp: ci/prow/eval

Details

In response to this:

/override ci/prow/eval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wking

wking commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

/verified by me, just a rename, consumer is tech-preview, I'll test post-merge

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 13, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@wking: This PR has been marked as verified by me,just a rename,consumer is tech-preview,I'll test post-merge.

Details

In response to this:

/verified by me, just a rename, consumer is tech-preview, I'll test post-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 8d17bad into openshift:main Aug 13, 2026
4 checks passed
@wking
wking deleted the cluster-update-advisor-directory branch August 13, 2026 23:15
wking added a commit to wking/cluster-version-operator that referenced this pull request Aug 14, 2026
Catch up with openshift/agentic-skills@9d6d4b97c2
(cluster-update/cluster-update-advisor: Rename to match skill name,
2026-08-14, openshift/agentic-skills#47).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants