Repository navigation
Allow clusterless jobs #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
bb5f58d
e0a0adb
2799de7
af0811e
16fa1d1
dbbcbbf
12844a4
6eefadb
834184e
4254b58
0e0f4ec
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -176,16 +176,14 @@ def _resolve_hardware( | |
|
|
||
| if not gpu_type or not gpu_count: | ||
| if not exclusive_lock: | ||
| _resolve_failed( | ||
| patch, | ||
| conditions, | ||
| # Hardware is optional for non-exclusive jobs (including clusterless) | ||
| logger.info( | ||
| "Job %s: non-exclusive job without hardware — " | ||
| "Workload will only request cluster-slot resources", | ||
| name, | ||
| "No hardware requirements: spec.hardware not populated " | ||
| "after resolution", | ||
| reason="NoHardware", | ||
| cond_message="No hardware requirements found", | ||
| ) | ||
| return None, None | ||
| return None, 0 | ||
|
|
||
| logger.warning( | ||
| "Job %s: exclusive cluster lock without hardware — " | ||
| "Workload will only request cluster-slot resources " | ||
|
|
@@ -333,6 +331,23 @@ def reconcile_resolving(spec, name, status, patch, body): | |
|
|
||
| if not _validate_secret_refs(spec, name, conditions, patch): | ||
| return | ||
| _create_workload_and_transition( | ||
| spec, name, conditions, patch, body, gpu_type, gpu_count | ||
| ) | ||
|
|
||
| clusterless = spec.get("clusterless", False) | ||
| if clusterless: | ||
| # Skip Kueue entirely for clusterless jobs - go directly to Admitted phase | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this bypass happens at the very end, so every clusterless job still spins up a resolve Job and waits for it before skipping Kueue
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, the resolve step is important to fill the fjob with the secrets required for running the job (in addition to telling the HW request -- that we don't use so far) |
||
| patch.status["phase"] = Phase.ADMITTED | ||
| patch.status["cluster"] = "[clusterless]" | ||
| patch.status["message"] = "Clusterless job ready for execution" | ||
| set_condition( | ||
| patch, | ||
| conditions, | ||
| COND_WORKLOAD_ADMITTED, | ||
| "True", | ||
| "ClusterlessAdmitted", | ||
| "Clusterless job bypassed Kueue admission", | ||
| ) | ||
| logger.info("Job %s: clusterless job bypassing Kueue, phase=Admitted", name) | ||
| else: | ||
| _create_workload_and_transition( | ||
| spec, name, conditions, patch, body, gpu_type, gpu_count | ||
| ) | ||
Uh oh!
There was an error while loading. Please reload this page.