Repository navigation
Update to make it work with Forge - #26
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 1 minutes and 24 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughUpdated README deployment/onboarding commands and FORGE apply sequence; adjusted a Tekton Task step's shell options and environment setup; added a script to copy Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@hacks/copy-kubeconfig-secrets-to-ns.sh`:
- Line 15: The loop over SECRET_NAME using `oc get secrets -n $SOURCE_NS -o name
| grep "\-kubeconfig"` will cause the script to abort under set -o pipefail and
errexit when grep finds no matches; modify the logic in
hacks/copy-kubeconfig-secrets-to-ns.sh to capture the grep output safely (e.g.,
assign the results of `oc get secrets ... | grep "\-kubeconfig"` to a variable
or array using `$(...)` or readarray and use `|| true`), then check if that
variable/array is empty and either print a clean message and skip processing (or
exit 0) when there are no matching secrets, and only iterate over SECRET_NAME
when non-empty; reference the loop variable SECRET_NAME and the `oc get secrets
-n $SOURCE_NS -o name` pipeline when making the change.
- Around line 20-28: The current pipeline uses oc create to write the
transformed secret into the target namespace (the oc get ... | oc create -n
"$TARGET_NS" -f - pipeline that references SECRET_NAME, SOURCE_NS, TARGET_NS),
which fails if the secret already exists; update that final command to use oc
apply -n "$TARGET_NS" -f - so the operation is idempotent (creates when missing,
updates when present) while keeping the existing jq deletions of metadata
fields.
In `@README.md`:
- Around line 199-201: The pipeline in the README uses separate commands that
aren't connected—ensure the YAML is streamed through sed into oc by piping cat
into sed and then into oc, and use sed with the variable substitution for
$FOURNOS_NAMESPACE and have oc read from stdin (e.g., via -f -); update the
commands around the cat/sed/oc sequence so sed receives the file input and oc
apply consumes the substituted YAML.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7c506150-ca30-40a6-b3b8-476146099a53
📒 Files selected for processing (8)
README.mdconfig/forge/images/build_forge-main.yamlconfig/forge/images/buildrun_forge-main.yamlconfig/forge/images/is_forge.yamlconfig/forge/workflows/tasks.yamlhacks/copy-kubeconfig-secrets-to-ns.shmanifests/ocpci-sa/rbac-wip-ns.yamlmanifests/ocpci-sa/role.yaml
e124f1e to
6a34d35
Compare
…sap-automation-wip NS
…g secrets to another namespace
…y options and remove 'set -x'
2 participants
config: forge: images: rename the files for more consistencyREADME: update/fix the file locationsmanifests: ocpci-sa: role: allow the OCPCI-SA to delete fjobsmanifests: ocpci-sa: rbac-wip-ns: add RBAC for OCPI-CI sa to access psap-automation-wip NShacks: copy-kubeconfig-secrets-to-ns: script to migrate the kubeconfig secrets to another namespaceconfig: forge: workflows/tasks: expose the ARTIFACT_DIR and FOURNOS_CI env varsonfig: forge: workflows/tasks: use the long version of the bash safety optionsand remove 'set -x'
config: forge: workflows/tasks: don't source the env filenot safe
Summary by CodeRabbit
Documentation
New Features
Updates