fix: allow TTL garbage collection to delete jobs

[Harshith-umesh]

Summary

• Grant the Fournos controller delete permission on fournosjobs.
• Allow the TTL garbage collector introduced by feat: add spec.ttl for automatic job cleanup after completion #118 to remove expired terminal FJobs.

Validation

• TTL test suite: 22 passed.
• WIP verification confirmed expired FJobs are deleted once this permission is present.
• Existing FJobs without TTL remain retained.

The CRD remains deployed separately from the GitOps Application.

Summary by CodeRabbit

• New Features
  • Authorized users can now delete Fournos jobs, including their status and finalizer subresources.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 3da0d06c-5a85-4400-859b-c7a8e83bb3b8

📥 Commits

Reviewing files that changed from the base of the PR and between b424d51 and 7bf44b9.

📒 Files selected for processing (1)

• manifests/rbac/role_fournos.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The Fournos Role now grants the delete verb for fournosjobs and their status and finalizers subresources.

Changes

Fournos RBAC permissions

Layer / File(s)	Summary
Add FournosJob delete permission manifests/rbac/role_fournos.yaml	The Fournos Role now grants delete access to fournosjobs, fournosjobs/status, and fournosjobs/finalizers.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 7bf44

The controller can now remove expired terminal FournosJobs while existing non-TTL jobs remain unaffected.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: granting permission for TTL garbage collection to delete expired jobs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[kpouget]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kpouget

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kpouget]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment