[core] Finish updating the get_ci_metadata_dir function

[kpouget]

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability when accessing CI metadata and notification files by ensuring the required metadata directory is created automatically.
  • Updated artifact review, failure analysis, export status, and notification workflows to consistently use the correct metadata location.
  • Prevented failures caused by missing metadata directories during job processing and notification delivery.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign harshith-umesh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kpouget]

/test fournos skeleton

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 6d12e035-b51b-4e41-b9d5-36baee77cfcc

📥 Commits

Reviewing files that changed from the base of the PR and between 1234fe1 and 2514d57.

📒 Files selected for processing (6)

• projects/core/agentic/config_review/__init__.py
• projects/core/agentic/on_failure/__init__.py
• projects/core/library/ci.py
• projects/core/library/export.py
• projects/core/notifications/send.py
• projects/fournos_launcher/orchestration/submit.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The CI metadata location helper now creates the metadata directory before returning it. Metadata consumers now use this helper for artifact files, notifications, job status, and pull-request configuration paths.

Changes

CI metadata path handling

Layer / File(s)	Summary
Create the CI metadata directory projects/core/library/ci.py	get_ci_metadata_dir_location() creates 000__ci_metadata with parent directories before returning its path.
Migrate metadata consumers projects/core/agentic/..., projects/core/library/export.py, projects/core/notifications/send.py, projects/fournos_launcher/orchestration/submit.py	Metadata lookups for artifact files, notifications, FournosJob status, and pr_config.txt now use get_ci_metadata_dir_location(). The existing configuration fallback remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 2514d

The metadata directory is created idempotently and the migrated consumers retain compatible metadata paths, so the change is mergeable.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 6 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: completing the migration from the older CI metadata directory access pattern to the updated location helper across the affected modules.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[psap-forge-bot]

✅ Execution of skeleton completed with success after 19s ✅

forge-skeleton-20260916-100207 -- skeleton

---

Execution Engine Configuration

executionEngine:
  forge:
    args: []
    configOverrides: {}
    project: skeleton
owner: kpouget
pipeline: forge-test-only

---

MLFlow links

• mlflow results
  • nested run load
  • nested run smoke

---

Pipeline Step Details

✅ 00__preflight 1 second

✅ 01__test 18 seconds

• 📊 Test directory: 001__skeleton_seed_data_for_caliper_postprocessing/load
  • Test completed successfully (cluster info disabled)
  • test=skeleton, deep_testing=False, collect_cluster_info=False, scenario=load
  • Duration test: 0.0s, benchmark: 0.0s
• 📊 Test directory: 001__skeleton_seed_data_for_caliper_postprocessing/smoke
  • Test completed successfully (cluster info disabled)
  • test=skeleton, deep_testing=False, collect_cluster_info=False, scenario=smoke
  • Duration test: 0.0s, benchmark: 0.0s
• ✅ 002__postprocessing: ✔️ parse | ✔️ visualize | ✔️ artifacts_to_kpis | ✔️ kpis_to_mlflow | ⚪ dashboard_csv | ⚪ artifacts_to_ai_data | ✔️ s3_import | ✔️ analyse_kpis | ✔️ s3_export

📤 02__export-artifacts (🟡 8W)

• 🔒 Censoring Report
  • 📊 125 files scanned
  • ✅ Clean files: 125

---

✅ Post-processing Status /workspace/artifacts/01__test/002__postprocessing

• ✅ parse: success
• ✅ visualize: success
  • 📄 reports/throughput_chart.html
  • 📄 reports/summary_table.html
• ✅ artifacts_to_kpis: success
  • 🌐 kpis.html
  • 📄 kpis.json
• ✅ kpis_to_mlflow: success
• ⏭️ dashboard_csv: disabled
  • kpi.dashboard_csv disabled
• ⏭️ artifacts_to_ai_data: disabled
  • kpi.artifacts_to_ai_data disabled
• ✅ s3_import: success
• ✅ analyse_kpis: success
  • 🌐 kpi_analyze.html
  • 📊 kpi_analyze.json
  • No regression in 4 KPIs
• ✅ s3_export: success
  • 📤 Exported to: s3://psap-dashboard-data/smoke/skeleton-dashboard/26-09-16_100349_869/
  • ✅ Uploaded files: 2

[psap-forge-bot]

🟢 Submission of skeleton succeeded after 3 minutes, 5 seconds 🟢

• OCPCI Test results
• Task logs:
  • forge-skeleton-20260916-100207-00-preflight-pod.log
  • forge-skeleton-20260916-100207-01-test-pod.log
  • forge-skeleton-20260916-100207-02-export-artifacts-pod.log
  • forge-skeleton-20260916-100207-resolve-2wds6.log
• Execution logs
• MLFlow Test Results

/test fournos skeleton