Repository navigation
fix: update caliper postprocess config fields after PR 110 schema change - #118
Merged
openshift-merge-bot[bot] merged 3 commits intoJul 16, 2026
Conversation
PR 110 renamed caliper.postprocess.kpi fields: - kpi.generate -> kpi.artifacts_to_kpis - kpi.export -> removed (no longer needed) - analyze.baseline -> analyze.historical_kpis These three project configs were not updated, causing pydantic ValidationError (extra_forbidden) during postprocessing. Co-authored-by: Cursor <cursoragent@cursor.com>
📝 WalkthroughWalkthroughUpdated Caliper KPI configuration in three project YAML files and expanded Fournos documentation with pipeline variants, Git checkout behavior, and configuration examples. ChangesConfiguration and documentation updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add pipeline reference table and spec.env documentation (PULL_PULL_SHA, PULL_NUMBER, PULL_BASE_SHA) to the gitops README. Co-authored-by: Cursor <cursoragent@cursor.com>
Harshith-umesh
force-pushed
the
fix/caliper-postprocess-config-fields
branch
from
July 9, 2026 20:35
4c36f76 to
18eab4e
Compare
Contributor
|
can you move the doc to |
🟢 Execution of
|
Contributor
|
/lgtm |
Contributor
|
/approve |
openshift-ci
Bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kpouget The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@fournos/gitops/README.md`:
- Around line 40-53: Update the documented default in the Workflows section to
`forge-full`, matching the existing pipeline name in the table and the
`spec.pipeline` configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Comment on lines
+40
to
+53
| ### Workflows | ||
| - **Task**: `forge-step` — reusable Tekton task for executing forge commands | ||
| - **Pipelines**: | ||
|
|
||
| | Pipeline | Steps | Finally | Use case | | ||
| |---|---|---|---| | ||
| | `forge-full` | pre-cleanup → prepare → preflight → test | post-cleanup → export-artifacts | Full lifecycle with cleanup on both ends | | ||
| | `forge-prepare-test` | prepare → preflight → test | export-artifacts | Prepare + test without cleanup | | ||
| | `forge-test-only` | preflight → test | export-artifacts | Skip preparation, just run the test | | ||
| | `forge-prepare-only` | prepare → preflight | export-artifacts | Set up the cluster without benchmarks | | ||
| | `forge-replot` | replot | export-artifacts | Re-run visualization/postprocessing | | ||
|
|
||
| Select a pipeline via `spec.pipeline` in the FournosJob CR (default: `fournos-full`). | ||
|
|
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== README excerpt =="
nl -ba fournos/gitops/README.md | sed -n '30,70p'
echo
echo "== Search for pipeline names =="
rg -n --hidden --no-ignore-vcs '\b(forge-full|fournos-full|forge-prepare-test|forge-test-only|forge-prepare-only|forge-replot)\b' fournos/gitops . || true
echo
echo "== List gitops files =="
git ls-files fournos/gitopsRepository: openshift-psap/forge
Length of output: 219
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== README excerpt =="
sed -n '30,70p' fournos/gitops/README.md | cat -n
echo
echo "== Search for pipeline names =="
if command -v rg >/dev/null 2>&1; then
rg -n --hidden --no-ignore-vcs '\b(forge-full|fournos-full|forge-prepare-test|forge-test-only|forge-prepare-only|forge-replot)\b' fournos/gitops . || true
else
grep -RInE '\b(forge-full|fournos-full|forge-prepare-test|forge-test-only|forge-prepare-only|forge-replot)\b' fournos/gitops . || true
fi
echo
echo "== git ls-files under fournos/gitops =="
git ls-files fournos/gitopsRepository: openshift-psap/forge
Length of output: 5923
Make the documented default forge-full.
The table lists forge-full, but the default line says fournos-full, which doesn’t match any workflow name and will mislead users.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@fournos/gitops/README.md` around lines 40 - 53, Update the documented default
in the Workflows section to `forge-full`, matching the existing pipeline name in
the table and the `spec.pipeline` configuration.
Contributor
|
/lgtm |
Member
Author
|
/lgtm |
|
@Harshith-umesh: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
Author
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 110 renamed caliper.postprocess.kpi fields:
These three project configs were not updated, causing pydantic ValidationError (extra_forbidden) during postprocessing.
Summary by CodeRabbit
New Features
kpis.json.Bug Fixes
historical_kpis: nullwhile keeping analysis disabled.Documentation
FournosJobenvironment variable behavior for git checkout.