Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

RHODS: update RHODS version + various updates #400

Merged
merged 16 commits into from
Jun 30, 2022

Conversation

kpouget
Copy link
Collaborator

@kpouget kpouget commented Jun 28, 2022

  • rhods_test_jupyterlab: delete the PVC before running the test

  • rhods_test_jupyterlab: add 'Show failed tests' task

  • rhods_test_jupyterlab: use the Default notebook size

Instead of Small, which may randomly fail to show up.

See https://issues.redhat.com/browse/RHODS-1882


  • rhods_test_jupyterlab: allow 'no-image-except-if-failed' value for the the --artifacts-collected flag

  • testing: ods: jh-at-scale.sh: use no-image-except-if-failed artifact collection flag

  • testing: ods: process_ctrl: improve logging in wait_bg_processes

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from kpouget after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kpouget
Copy link
Collaborator Author

kpouget commented Jun 28, 2022

/test ods-jh-on-ocp

@kpouget
Copy link
Collaborator Author

kpouget commented Jun 28, 2022

flake :/

/test ods-jh-on-ocp

@kpouget
Copy link
Collaborator Author

kpouget commented Jun 29, 2022

/test ods-jh-on-ocp

@kpouget kpouget changed the title RHODS: various minor updates RHODS: update RHODS version + various minor updates Jun 29, 2022
@kpouget
Copy link
Collaborator Author

kpouget commented Jun 29, 2022

PR needs some updates, but the test is fine \o/

@kpouget
Copy link
Collaborator Author

kpouget commented Jun 29, 2022

/test ods-jh-on-ocp

@kpouget
Copy link
Collaborator Author

kpouget commented Jun 29, 2022

/test ods-jh-on-ocp

@kpouget
Copy link
Collaborator Author

kpouget commented Jun 29, 2022

test passed with 12 successes, 3 failures:

@kpouget
Copy link
Collaborator Author

kpouget commented Jun 29, 2022

  • failed users displayed with
2022-06-29 11:15:59,425 p=6171 u=psap-ci-runner n=ansible | roles/rhods_test_jupyterlab/tasks/main.yml:325
2022-06-29 11:15:59,425 p=6171 u=psap-ci-runner n=ansible | TASK: rhods_test_jupyterlab : Show failed tests
2022-06-29 11:15:59,425 p=6171 u=psap-ci-runner n=ansible | 
2022-06-29 11:15:59,426 p=6171 u=psap-ci-runner n=ansible | <command> grep  -v '^0$' "/logs/artifacts/008__driver_rhods__test_jupyterlab"/ods-ci/ods-ci-*/test.exit_code
2022-06-29 11:15:59,426 p=6171 u=psap-ci-runner n=ansible | 
2022-06-29 11:15:59,426 p=6171 u=psap-ci-runner n=ansible | <stdout> /logs/artifacts/008__driver_rhods__test_jupyterlab/ods-ci/ods-ci-11/test.exit_code:1
2022-06-29 11:15:59,426 p=6171 u=psap-ci-runner n=ansible | <stdout> /logs/artifacts/008__driver_rhods__test_jupyterlab/ods-ci/ods-ci-14/test.exit_code:3
2022-06-29 11:15:59,426 p=6171 u=psap-ci-runner n=ansible | <stdout> /logs/artifacts/008__driver_rhods__test_jupyterlab/ods-ci/ods-ci-3/test.exit_code:1
  • screenshots of failed users are collected

@kpouget
Copy link
Collaborator Author

kpouget commented Jun 29, 2022

test passed with 12 successes, 3 failures:

* [user 3](https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift-psap_ci-artifacts/400/pull-ci-openshift-psap-ci-artifacts-master-ods-jh-on-ocp/1542079799403483136/artifacts/jh-on-ocp/test/artifacts/008__driver_rhods__test_jupyterlab/ods-ci/ods-ci-3/test.log)

* [user 14](https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift-psap_ci-artifacts/400/pull-ci-openshift-psap-ci-artifacts-master-ods-jh-on-ocp/1542079799403483136/artifacts/jh-on-ocp/test/artifacts/008__driver_rhods__test_jupyterlab/ods-ci/ods-ci-14/test.log)

* [user 11](https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift-psap_ci-artifacts/400/pull-ci-openshift-psap-ci-artifacts-master-ods-jh-on-ocp/1542079799403483136/artifacts/jh-on-ocp/test/artifacts/008__driver_rhods__test_jupyterlab/ods-ci/ods-ci-11/test.log)

the users failed because their pod was running out of memory 🤦🏻 . Increased the memory request/limit to 750MB.
image

@kpouget
Copy link
Collaborator Author

kpouget commented Jun 29, 2022

/test ods-jh-on-ocp

@kpouget
Copy link
Collaborator Author

kpouget commented Jun 29, 2022

Failure is a flake of Ansible raised from there, I'm not sure what's happening ...

@kpouget kpouget closed this Jun 29, 2022
@kpouget kpouget reopened this Jun 29, 2022
@kpouget
Copy link
Collaborator Author

kpouget commented Jun 29, 2022

/test ods-jh-on-ocp

@kpouget
Copy link
Collaborator Author

kpouget commented Jun 29, 2022

/test ods-jh-on-ocp

@kpouget kpouget force-pushed the update branch 3 times, most recently from f945fd3 to 431e755 Compare June 29, 2022 17:03
@kpouget
Copy link
Collaborator Author

kpouget commented Jun 29, 2022

/test ods-jh-on-ocp

@kpouget
Copy link
Collaborator Author

kpouget commented Jun 29, 2022

flake
/test ods-jh-on-ocp

@kpouget
Copy link
Collaborator Author

kpouget commented Jun 29, 2022

/test ods-jh-on-ocp

1 similar comment
@kpouget
Copy link
Collaborator Author

kpouget commented Jun 30, 2022

/test ods-jh-on-ocp

@kpouget kpouget changed the title RHODS: update RHODS version + various minor updates RHODS: update RHODS version + various updates Jun 30, 2022
@kpouget
Copy link
Collaborator Author

kpouget commented Jun 30, 2022

looks good, merging.

@kpouget kpouget merged commit d9ed58a into openshift-psap:master Jun 30, 2022
@kpouget kpouget deleted the update branch June 30, 2022 07:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant