Skip to content

fix(ci): use exec.CommandContext to satisfy noctx linter #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zakisk
Copy link
Contributor

@zakisk zakisk commented Jul 23, 2025

πŸ“ Description of the Change

Replaced all direct calls to exec.Command with the context-aware
exec.CommandContext across CLI utilities and helper packages.

πŸš€ Type of Change

  • πŸ› Bug fix (fix:)
  • ✨ New feature (feat:)
  • πŸ’₯ Breaking change (feat!:, fix!:)
  • πŸ“š Documentation update (docs:)
  • βš™οΈ Chore (chore:)
  • πŸ’… Refactor (refactor:)
  • πŸ”§ Enhancement (enhance:)

βœ… Submitter Checklist

  • πŸ“ My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • β™½ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.

Replaced all direct calls to exec.Command with the context-aware
exec.CommandContext across CLI utilities and helper packages.

Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
@zakisk
Copy link
Contributor Author

zakisk commented Jul 23, 2025

/test

@chmouel
Copy link
Member

chmouel commented Jul 23, 2025

/merge

@zakisk
Copy link
Contributor Author

zakisk commented Jul 23, 2025

/test

@chmouel chmouel merged commit 3e8fe4c into openshift-pipelines:main Jul 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants