Disable Github comments for pipeline start/end events to reduce PR noise #2110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PuneetPunamiya
force-pushed
the
fix-too-many-comments-grom-github-integration
branch
2 times, most recently
from
68c63e5 to
1e10453
Compare
zakisk
reviewed
Jun 3, 2025
zakisk
reviewed
Jun 3, 2025
PuneetPunamiya
force-pushed
the
fix-too-many-comments-grom-github-integration
branch
from
1e10453 to
c921094
Compare
zakisk
force-pushed
the
fix-too-many-comments-grom-github-integration
branch
from
c921094 to
a4137fc
Compare
zakisk
reviewed
Jun 3, 2025
zakisk
reviewed
Jun 3, 2025
zakisk
reviewed
Jun 3, 2025
zakisk
reviewed
Jun 3, 2025
zakisk
reviewed
Jun 3, 2025
PuneetPunamiya
force-pushed
the
fix-too-many-comments-grom-github-integration
branch
2 times, most recently
from
d8735bb to
d1bc877
Compare
The Github webhook integration was previously generating a comment on every pipeline start and end filling pull requests with redundant updates Hence this patch introduces a new setting to completely disable comment creation By using `comment_strategy: disable_all`, no comments will be added for either pipeline start or completion Also includes e2e tests to validate the new behavior Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>
zakisk
force-pushed
the
fix-too-many-comments-grom-github-integration
branch
from
d1bc877 to
82930ff
Compare
|
/lgtm |
![pipelines-as-code[bot]](https://avatars.githubusercontent.com/in/112592?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats @PuneetPunamiya your PR Has been approved 🎉
✅ Pull Request Approved
Approval Status:
- Required Approvals: 1
- Current Approvals: 1
👥 Reviewers Who Approved:
| Reviewer | Permission Level | Approval Status |
|---|---|---|
| @zakisk | admin |
✅ |
📝 Next Steps
- Ensure all required checks pass
- Comply with branch protection rules
- Request a maintainer to merge using the
/mergecommand (or merge it
directly if you have repository permission).
Automated by the PAC Boussole 🧭
|
/merge |
pipelines-as-code
bot
merged commit 608c97b
into
openshift-pipelines:main
7 checks passed
✅ PR Successfully Merged
Approvals Summary:
Thank you @PuneetPunamiya for your valuable contribution! 🎉 Automated by the PAC Boussole 🧭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Github webhook integration was previously generating a comment on every pipeline start and end filling pull requests with redundant updates
Hence this patch introduces a new setting to completely disable comment creation
By using
comment_strategy: disable_all, no comments will be added for either pipeline start or completionAlso includes e2e tests to validate the new behavior
Changes
Submitter Checklist
📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).
♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.
✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).
📖 Document any user-facing features or changes in behavior.
🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.
🎁 If feasible, add an end-to-end test. See README for details.
If adding a provider feature, fill in the following details:
(update the provider documentation accordingly)