feat: Enable cluster wide cancel-in-progress setting via PAC ConfigMap

[zakisk]

Cancel-in-progress now can be enabled via PAC configMap using enable-cancel-in-progress-on-pull-requests and enable-cancel-in-progress-on-push fields for pull request and push events respectively. if a PipelineRun is having cancel-in-progress annotation specified explicitly then it will override setting from PAC configMap.

Changes

Submitter Checklist

• 📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).

• ♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.

• ✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).

• 📖 Document any user-facing features or changes in behavior.

• 🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.

• 🎁 If feasible, add an end-to-end test. See README for details.

• 🔎 Address any CI test flakiness before merging, or provide a valid reason to bypass it (e.g., token rate limitations).

• If adding a provider feature, fill in the following details:

  • GitHub App
  • GitHub Webhook
  • Gitea/Forgejo
  • GitLab
  • Bitbucket Cloud
  • Bitbucket Data Center

  (update the provider documentation accordingly)

[zakisk]

linteres is failing on 😕

pkg/pipelineascode/cancel_pipelineruns.go:56: NotIn ==> noting, not in, notion
pkg/pipelineascode/cancel_pipelineruns_test.go:1525: NotIn ==> noting, not in, notion
pkg/pipelineascode/cancel_pipelineruns_test.go:1526: notin ==> noting, not in, notion

[chmouel]

linteres is failing on 😕

pkg/pipelineascode/cancel_pipelineruns.go:56: NotIn ==> noting, not in, notion
pkg/pipelineascode/cancel_pipelineruns_test.go:1525: NotIn ==> noting, not in, notion
pkg/pipelineascode/cancel_pipelineruns_test.go:1526: notin ==> noting, not in, notion

can you send a pr ?

[zakisk]

can you send a pr ?

yes

[zakisk]

@chmouel codespell PR #2055

[Copilot]

Pull Request Overview

This PR introduces functionality to enable cancel‐in‐progress for both pull request and push events via the PAC ConfigMap. Key changes include:

• Adding new functions in test/pkg/github/setup.go to patch the PAC ConfigMap.
• Implementing cancel‐in‐progress logic in pkg/pipelineascode and updating the corresponding tests.
• Updating configuration, settings, and documentation to support the new cancel‐in‐progress flags.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
test/pkg/github/setup.go	Added helper functions to patch PAC ConfigMap and reset settings.
test/github_pullrequest_test.go	New tests for verifying cancel‐in‐progress behavior for PR and push.
pkg/pipelineascode/pipelineascode.go	Renamed and updated cancellation function invocation.
pkg/pipelineascode/cancel_pipelineruns.go	Updated label selector construction and cancellation condition logic.
pkg/params/settings/convert_test.go	Added new config fields for cancel‐in‐progress.
pkg/params/settings/config_test.go	Added tests for new cancel‐in‐progress settings.
pkg/params/settings/config.go	Integrated new boolean fields into Settings.
docs/content/docs/install/settings.md	Added documentation for cancel‐in‐progress settings.
docs/content/docs/install/operator_installation.md	Updated installation docs with new cancel‐in‐progress options.
config/302-pac-configmap.yaml	Added new config keys for global cancel‐in‐progress behavior.

Comments suppressed due to low confidence (2)

test/pkg/github/setup.go:124

• Instead of calling log.Fatalf on marshalling errors in PatchPACConfigMap, consider returning the error so that it can be handled gracefully by the caller.

if err != nil { log.Fatalf("Failed to marshal patch data: %v", err) }

test/pkg/github/setup.go:155

• In SetCancelInProgressToDefaults, returning the error instead of calling log.Fatalf would improve error propagation and allow the caller to handle the failure appropriately.

if err != nil { log.Fatalf("Failed to marshal patch data: %v", err) }

[chmouel]

this looks good to me, just a comment about some duplication..

I'd like to enable this by default on our dogfooding cluster, please ping me to let you know how to do that