Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tkn approvaltask describe command #153

Conversation

PuneetPunamiya
Copy link
Collaborator

@PuneetPunamiya PuneetPunamiya commented May 8, 2024

  • ApprovalTask Describe Command UX
╰─ ./tkn-approvaltask describe test-6mml7-wait       
📦 Name:              test-6mml7-wait
🗂  Namespace:        default
🏷️  PipelineRunRef:   test-6mml7 

👥 Approvers
   * foo
   * bar
   * kubernetes-admin

👨‍💻 ApproverResponse

Name   ApproverResponse   Message
foo    ✅                  ---

🌡️  Status

NumberOfApprovalsRequired   PendingApprovals   STATUS
2                           1                  Pending

@openshift-ci openshift-ci bot requested review from concaf and vdemeester May 8, 2024 19:02
Copy link

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PuneetPunamiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 8, 2024
@PuneetPunamiya PuneetPunamiya force-pushed the add-tkn-approvaltask-describe-command branch 2 times, most recently from 0d46326 to e1bf3f0 Compare May 14, 2024 04:30
This patch also adds e2e tests for describe command CLI

Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>
@PuneetPunamiya PuneetPunamiya force-pushed the add-tkn-approvaltask-describe-command branch from e1bf3f0 to a47c779 Compare May 14, 2024 04:47
@piyush-garg
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 14, 2024
@piyush-garg piyush-garg merged commit 7039eba into openshift-pipelines:main May 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants