-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tkn approvaltask 😻 #141
Add tkn approvaltask 😻 #141
Conversation
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PuneetPunamiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3495f89
to
a8ffc00
Compare
fa6410e
to
aba7dfc
Compare
162799f
to
ae376d6
Compare
ae376d6
to
4cfe7ef
Compare
5674713
to
13d2a38
Compare
/hold cancel |
Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>
13d2a38
to
eb7c4f3
Compare
"Pending": color.FgHiBlue, | ||
} | ||
|
||
const listTemplate = `{{- $at := len .ApprovalTasks.Items }}{{ if eq $at 0 -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This table makes not much sense for me. Too much information repeated. We can go for something like
NAME Approvals STATUS
foo 2/3 Wait
bar 4/4 Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are supporting only single reject, showing a column does not make any sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@piyush-garg I am fine with it as long as its clear that in the example of 0/3 and status as "rejected" someone from the approval list has rejected it.
Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>
Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>
eb7c4f3
to
b6ad294
Compare
Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>
b6ad294
to
a7bf9fa
Compare
var ConditionColor = map[string]color.Attribute{ | ||
"Rejected": color.FgHiRed, | ||
"Approved": color.FgHiGreen, | ||
"Pending": color.FgHiBlue, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be yellow/orange :D
/lgtm |
This patch bootstraps CLI and adds implementation of List Command
Output