Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes API server as we can use existing CRD API's #113

Merged

Conversation

PuneetPunamiya
Copy link
Collaborator

This patch removes following

  • Removes implementation of API server that lists and updates the approvaltask
  • Removes the config files of API server
  • Fixes e2e Test

@openshift-ci openshift-ci bot requested a review from vdemeester January 18, 2024 09:28
This patch removes following

  - Removes implementation of API server
  - Removes the config files of API server

Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>
Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PuneetPunamiya, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 91b7eba into openshift-pipelines:main Jan 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants