OCPEDGE-1192: feat: initial arbiter node addition

[eggfoobar]

added support for creating install for clusters with arbiter nodes

In 4.19 of OCP, we will be supporting a deployment with Two Node Openshift with Arbiter on the baremetal platform, this PR adds the arbiter configuration to the metal scripts to help deploy and test arbiter topologies for baremetal.

For more details see EP: openshift/enhancements#1674

[openshift-ci]

Hi @eggfoobar. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[eggfoobar]

/hold

Currently running int an odd issue where I'm not sure if it's a problem with the devscript or not. But the arbiter node takes around 10minutes to join the cluster because the inspecting phase takes too long. @zaneb Would you be able to know why that is?

I did create this PR in baremetal for the provisioning controller, but don't if I'm missing something else here. openshift/cluster-baremetal-operator#460

[iurygregory]

/ok-to-test

[zaneb]

No idea about the inspection thing.

Creating a new node type and duplicating all of the config for it seems like a... high-maintenance way to do this. Couldn't we treat the arbiter node as a control-plane node everywhere except when generating the install config?

[eggfoobar]

Hey @zaneb and @dtantsur, thanks for the recommendations, I trimmed back all the additional files to only the required parts for deploying the arbiter node. Currently, we don't need much of the other features of the scripts here, so the changes only revolve around altering the install config and adding a new arbiter flavor that will only get triggered when the arbiter is enabled. The flavor addition of the arbiter is there to help create smaller arbiter nodes in CI since we wish to test the heterogenous deployment.

[eggfoobar]

/unhold

The issue I had mentioned earlier has been resolved, no reason to have a hold on this PR anymore.

[elfosardo]

/retest

[dtantsur]

/approve

@eggfoobar could you add the new variables to https://github.com/openshift-metal3/dev-scripts/blob/master/config_example.sh with an explanation how to use them? (e.g. how to set NUM_MASTERS)

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dtantsur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[eggfoobar]

/approve

@eggfoobar could you add the new variables to https://github.com/openshift-metal3/dev-scripts/blob/master/config_example.sh with an explanation how to use them? (e.g. how to set NUM_MASTERS)

Yeah absolutely, updated!

[eggfoobar]

/retest

[eggfoobar]

/retest

[eggfoobar]

@dtantsur This should be all set now, thanks for the input!

[derekhiggins]

/lgtm