-
Notifications
You must be signed in to change notification settings - Fork 62
Add ethtool -k and ethtool -l to must gather collected data #935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ethtool -k and ethtool -l to must gather collected data #935
Conversation
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
Pull Request Test Coverage Report for Build 2591
💛 - Coveralls |
|
do we have a test for that ? or what is tested in a different method ? |
the tests are in NTO: https://github.com/openshift/cluster-node-tuning-operator/pull/365/files But it is needed to upload new data. I want to do a new test with real data generated in the cluster, when that PR will be merged I will add the test for these files also. |
|
After this one we can add test in NTO |
|
/override ci/prow/e2e-gcp |
|
@fromanirh: Overrode contexts on behalf of fromanirh: ci/prow/e2e-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-gcp-operator-upgrade |
|
@fromanirh: Overrode contexts on behalf of fromanirh: ci/prow/e2e-gcp-operator-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fromanirh, marioferh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add ethtool -k and ethtool -l to must gather collected data
Save in ethtool_features and ethtool_channels files
Signed-off-by: Mario Fernandez mariofer@redhat.com