Skip to content

Conversation

@marioferh
Copy link
Contributor

Add ethtool -k and ethtool -l to must gather collected data
Save in ethtool_features and ethtool_channels files

Signed-off-by: Mario Fernandez mariofer@redhat.com

Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@openshift-ci openshift-ci bot requested review from MarSik and jlojosnegros August 17, 2022 18:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2591

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.463%

Totals Coverage Status
Change from base Build 2581: 0.0%
Covered Lines: 1644
Relevant Lines: 2719

💛 - Coveralls

@yanirq
Copy link
Member

yanirq commented Aug 18, 2022

do we have a test for that ? or what is tested in a different method ?

@marioferh
Copy link
Contributor Author

do we have a test for that ? or what is tested in a different method ?

the tests are in NTO: https://github.com/openshift/cluster-node-tuning-operator/pull/365/files

But it is needed to upload new data. I want to do a new test with real data generated in the cluster, when that PR will be merged I will add the test for these files also.

@marioferh
Copy link
Contributor Author

After this one we can add test in NTO
openshift/cluster-node-tuning-operator#442

@marioferh
Copy link
Contributor Author

@ffromani
Copy link
Member

/override ci/prow/e2e-gcp

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022

@fromanirh: Overrode contexts on behalf of fromanirh: ci/prow/e2e-gcp

In response to this:

/override ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ffromani
Copy link
Member

/override ci/prow/e2e-gcp-operator-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022

@fromanirh: Overrode contexts on behalf of fromanirh: ci/prow/e2e-gcp-operator-upgrade

In response to this:

/override ci/prow/e2e-gcp-operator-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ffromani
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh, marioferh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
@openshift-merge-robot openshift-merge-robot merged commit 26ca478 into openshift-kni:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants