gh actions: add workflow to build tool #927
Conversation
Pull Request Test Coverage Report for Build 2579
💛 - Coveralls |
|
need to add a new tag from master to enable this workflow to run correctly and provide releases with the tool binary. |
ffromani
left a comment
ffromani
left a comment
There was a problem hiding this comment.
nice work. I'm in favour of adding GH actions support for this repo (which is in maintenance mode anyway) and for this purpose.
Let's just fix the possible release name clash (see inline comment) and let's get consensus with other devs.
| - name: release the tool binary | ||
| uses: ncipollo/release-action@v1 | ||
| with: | ||
| name: hugepagesmcgenartor |
There was a problem hiding this comment.
can we remove the explicit name? this way the release name should be the same as the tag name - which is a bit better. Right?
There was a problem hiding this comment.
correct! will modify it, thanks!
Add new workflow to build and release binary for tools/hugepages-machineconfig-generator to enable using it externally.
ffromani
left a comment
ffromani
left a comment
There was a problem hiding this comment.
/lgtm
/hold
adding gh actions is a good thing in general, and so is having the PAO tools easily available.
We expect to make few runs in general and in this repo in particular - being on maintenance mode
Low risk, high gain.
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest-required |
it is good to have a full green run, but for this specific PR we can safely override failing lines. Adding github actions config can't possibly break any production flow (or test code) |
|
/override ci/prow/e2e-gcp-operator-upgrade |
|
@shajmakh: shajmakh unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
don't worry, I can override once we reach consensus :) we only need more LGTMs |
|
/lgtm |
|
/override ci/prow/e2e-gcp-operator-upgrade |
|
@fromanirh: Overrode contexts on behalf of fromanirh: ci/prow/e2e-gcp, ci/prow/e2e-gcp-operator-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fromanirh, shajmakh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
5 participants
Add new workflow to build and release binary for tools/hugepages-machineconfig-generator to enable using it externally.