Skip to content

Conversation

@jlojosnegros
Copy link
Contributor

@jlojosnegros jlojosnegros commented Jun 21, 2022

From v0.1.7 debug-tools has a new podinfo command to help us to gather
info from pods to complement PodResourcesAPI info.
The information gathered is the same that was gotten with the current
oc command.

@openshift-ci openshift-ci bot requested review from swatisehgal and yanirq June 21, 2022 07:44
@coveralls
Copy link

coveralls commented Jun 21, 2022

Pull Request Test Coverage Report for Build 2516

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.508%

Totals Coverage Status
Change from base Build 2490: 0.0%
Covered Lines: 1644
Relevant Lines: 2717

💛 - Coveralls

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2022

@jlojosnegros: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-upgrade 54b1a3e link false /test e2e-gcp-operator-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

From v1.7 `debug-tools` has a new `podinfo` command to help us to gather
info from pods to complement PodResourcesAPI info.
The information gathered is the same that was gotten with the current
`oc` command.
Copy link
Member

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh, jlojosnegros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2022
@jlojosnegros
Copy link
Contributor Author

I think there are two Ci lanes that still need to be overridden:

/override ci/prow/e2e-gcp-operator-upgrade
/override ci/prow/e2e-gcp

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2022

@jlojosnegros: jlojosnegros unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to this:

I think there are two Ci lanes that still need to be overridden:

/override ci/prow/e2e-gcp-operator-upgrade
/override ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 1fb5210 into openshift-kni:master Jun 21, 2022
@jlojosnegros
Copy link
Contributor Author

/cherry-pick release-4.10

@openshift-cherrypick-robot

@jlojosnegros: new pull request created: #908

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlojosnegros
Copy link
Contributor Author

/cherry-pick release-4.9

@openshift-cherrypick-robot

@jlojosnegros: #907 failed to apply on top of branch "release-4.9":

Applying: Use new `podinfo` command to gather pod data
.git/rebase-apply/patch:123: trailing whitespace.
		"namespace":"{{.ObjectMeta.Namespace}}", 
.git/rebase-apply/patch:124: trailing whitespace.
		"name":"{{.ObjectMeta.Name}}", 
.git/rebase-apply/patch:125: trailing whitespace.
		"nodeName":"{{.Spec.NodeName}}", 
.git/rebase-apply/patch:126: trailing whitespace.
		"qosClass": "{{.Status.QOSClass}}", 
.git/rebase-apply/patch:130: trailing whitespace.
			{{- if (ne $cdx 0) }},{{ end }} 
warning: squelched 6 whitespace errors
warning: 11 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	must-gather/collection-scripts/gather_nodes
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Auto-merging must-gather/collection-scripts/gather_nodes
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Use new `podinfo` command to gather pod data
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlojosnegros
Copy link
Contributor Author

/cherry-pick release-4.8

@openshift-cherrypick-robot

@jlojosnegros: #907 failed to apply on top of branch "release-4.8":

Applying: Use new `podinfo` command to gather pod data
.git/rebase-apply/patch:123: trailing whitespace.
		"namespace":"{{.ObjectMeta.Namespace}}", 
.git/rebase-apply/patch:124: trailing whitespace.
		"name":"{{.ObjectMeta.Name}}", 
.git/rebase-apply/patch:125: trailing whitespace.
		"nodeName":"{{.Spec.NodeName}}", 
.git/rebase-apply/patch:126: trailing whitespace.
		"qosClass": "{{.Status.QOSClass}}", 
.git/rebase-apply/patch:130: trailing whitespace.
			{{- if (ne $cdx 0) }},{{ end }} 
warning: squelched 6 whitespace errors
warning: 11 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	must-gather/collection-scripts/gather_nodes
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Auto-merging must-gather/collection-scripts/gather_nodes
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Use new `podinfo` command to gather pod data
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants