Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNF-14785: Validate new spoke CR to be managed by the ACM PG #263

Merged
merged 1 commit into from
Oct 18, 2024
Merged

CNF-14785: Validate new spoke CR to be managed by the ACM PG #263

merged 1 commit into from
Oct 18, 2024

Conversation

irinamihai
Copy link
Collaborator

No description provided.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 16, 2024 •
edited by openshift-ci bot
Loading

@irinamihai: This pull request references CNF-14785 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from browsell October 16, 2024 22:08
@bartwensley
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2024
@edcdavid
Copy link
Collaborator

/lgtm

@Missxiaoguo
Copy link
Collaborator

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Missxiaoguo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1f10e37 into openshift-kni:main Oct 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Missxiaoguo Missxiaoguo Missxiaoguo left review comments

@edcdavid edcdavid edcdavid left review comments

@bartwensley bartwensley Awaiting requested review from bartwensley

@browsell browsell Awaiting requested review from browsell

Assignees

@bartwensley bartwensley

@edcdavid edcdavid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@irinamihai @openshift-ci-robot @bartwensley @edcdavid @Missxiaoguo