-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement for alarms #215
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
docs/enhancements/infrastructure-monitoring-service-api/lifecycle.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/lifecycle.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/lifecycle.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/lifecycle.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/lifecycle.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/lifecycle.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/lifecycle.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/lifecycle.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/lifecycle.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/lifecycle.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General question about DB serial number. It will increase with the entry of DB rows or increase with DB row update?
docs/enhancements/infrastructure-monitoring-service-api/lifecycle.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/lifecycle.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/lifecycle.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/lifecycle.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/lifecycle.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/lifecycle.md
Outdated
Show resolved
Hide resolved
@Jennifer-chen-rh on entry. More on SERIAL datatypes https://www.postgresql.org/docs/current/datatype-numeric.html#DATATYPE-SERIAL. But we can have custom type which be incremented on insertion or update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pixelsoccupied aha, I felt something missing in PR. Now I figured out that the section we discussed about history table entry age out not here.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the datastructures are still public
- Missing the the alarm notification event object structure
9e69f7c
to
ce256ad
Compare
ce256ad
to
e60ffbc
Compare
docs/enhancements/infrastructure-monitoring-service-api/alarms.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/alarms.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/alarms.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/alarms.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/alarms.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/alarms.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/alarms.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/alarms.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/alarms.md
Outdated
Show resolved
Hide resolved
docs/enhancements/infrastructure-monitoring-service-api/alarms.md
Outdated
Show resolved
Hide resolved
…rver and add david as reviewer
This enhancement talks about re-architecting the Alarm server as specified in
InfrastructureMonitoring Service API
o-ran spec.Notable changes include:
This enhancement includes all the code tested during spike, the k8s resources needed to deploy through operator and other libraries/tool that can be used to quickly develop this.
co-authored with @browsell and @Jennifer-chen-rh