Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

naming: change mutual cpus to shared cpus #17

Closed
wants to merge 1 commit into from
Closed

naming: change mutual cpus to shared cpus #17

wants to merge 1 commit into from

Conversation

Tal-or
Copy link
Collaborator

@Tal-or Tal-or commented Oct 18, 2023

This name is more intuitive and its the one that will used across the code base, documentation, glossary, etc.

@Tal-or
naming: change mutual cpus to shared cpus
739f3f3 
This name is more intuitive and its the one that will used
across the code base, documentation, glossary, etc.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
ffromani
ffromani reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

should we rename also files/dirs like test/e2e/mixedcpus/mixedcpus.go ? I think yes (another PR is fine)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@Tal-or
Copy link
Collaborator Author

Tal-or commented Oct 18, 2023

/lgtm

should we rename also files/dirs like test/e2e/mixedcpus/mixedcpus.go ? I think yes (another PR is fine)

This is actually the name of the feature in general this is not mutualcpus.go

@ffromani
Copy link
Member

/lgtm
should we rename also files/dirs like test/e2e/mixedcpus/mixedcpus.go ? I think yes (another PR is fine)

This is actually the name of the feature in general this is not mutualcpus.go

fair enough

@Tal-or
Copy link
Collaborator Author

Tal-or commented Oct 22, 2023

/retest

1 similar comment
@Tal-or
Copy link
Collaborator Author

Tal-or commented Dec 26, 2023

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 26, 2023

@Tal-or: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-e2e 739f3f3 link true /test ci-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Tal-or Tal-or closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffromani ffromani ffromani left review comments

@swatisehgal swatisehgal Awaiting requested review from swatisehgal

@yanirq yanirq Awaiting requested review from yanirq

Assignees

@ffromani ffromani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tal-or @ffromani