Skip to content

Remove trademark #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tonyskapunk merged 1 commit into from
Dec 10, 2024
Merged

Remove trademark #106

tonyskapunk merged 1 commit into from
Dec 10, 2024

Conversation

@betoredhat
Copy link
Collaborator

@betoredhat betoredhat commented Dec 9, 2024 •
edited by tonyskapunk
Loading

HasRequiredLabel check is failing as it validates that container labels do not contain references to Red Hat. See: redhat-openshift-ecosystem/openshift-preflight@ee9611b#diff-7f30e90a5ee0fb5b3ef312b3676e6894d2e027a6ee178e3cd3fd13af68f15e8eR44

@betoredhat
Copy link
Collaborator Author

betoredhat commented Dec 9, 2024

recheck

@betoredhat betoredhat mentioned this pull request Dec 9, 2024
Open
@dcibot
Copy link

dcibot commented Dec 9, 2024

from change #106:

  • ERROR no DCI job found

@dcibot
Copy link

dcibot commented Dec 9, 2024

from change #106:

@dcibot
Copy link

dcibot commented Dec 9, 2024

from change #106:

@dcibot
Copy link

dcibot commented Dec 10, 2024

from change #106:

@tonyskapunk
Copy link
Collaborator

tonyskapunk commented Dec 10, 2024

retest

@ramperher
Copy link
Collaborator

ramperher commented Dec 10, 2024

Testing this on preflight pipeline will not work since the image used there is hardcoded (and really old), and preflight-green is no longer testing example-cnf images.
This needs to be tested only in example-cnf pipeline, I'll check that in BOS2.
From my side, the change looks fine but we need to validate it with example-cnf before.

@ramperher ramperher mentioned this pull request Dec 10, 2024
Merged
1 task
@dcibot
Copy link

dcibot commented Dec 10, 2024

from change dci-labs/example-cnf-config#115:

manurodriguez
manurodriguez approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@manurodriguez manurodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the preflight tests HasRequiredLabel passed with example-cnf operators, but the job failed with a non related issue with CNF certsuite tests,

tonyskapunk
tonyskapunk approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@tonyskapunk tonyskapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, passing tests:
https://www.distributed-ci.io/jobs/296f4a79-b55d-4ffd-97a7-2d79eab66f85/tests/efb88cfa-c53b-42e7-9d1a-aad1b79137f9?testcase=HasRequiredLabel
https://www.distributed-ci.io/jobs/296f4a79-b55d-4ffd-97a7-2d79eab66f85/tests/fd1caf76-99b2-48b5-8508-72130958c84a?testcase=HasRequiredLabel
https://www.distributed-ci.io/jobs/296f4a79-b55d-4ffd-97a7-2d79eab66f85/tests/712bcc38-dcce-4a6a-b3d3-0af5c3148458?testcase=HasRequiredLabel
https://www.distributed-ci.io/jobs/296f4a79-b55d-4ffd-97a7-2d79eab66f85/tests/516d2270-a802-49e6-9ac6-47c7a7629654?testcase=HasRequiredLabel
https://www.distributed-ci.io/jobs/296f4a79-b55d-4ffd-97a7-2d79eab66f85/tests/1aba1bb1-e84d-4d6f-b2e1-e6ae7e9cb753?testcase=HasRequiredLabel
https://www.distributed-ci.io/jobs/296f4a79-b55d-4ffd-97a7-2d79eab66f85/tests/cadcc10c-694e-498d-9f4b-4eb40ced717f?testcase=HasRequiredLabel

@tonyskapunk tonyskapunk merged commit 1f8c12a into main Dec 10, 2024
1 check passed
@tonyskapunk tonyskapunk deleted the trademark branch December 10, 2024 20:04
@ramperher ramperher mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonyskapunk tonyskapunk tonyskapunk approved these changes

@manurodriguez manurodriguez manurodriguez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@betoredhat @dcibot @tonyskapunk @ramperher @manurodriguez