Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Index yaml entries for older channels correctly #2583

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Mar 27, 2024

For older channels, we ignore micro-releases and only use the initial version from those streams because we don't know how many micro release will be in that stream in advance.

Related to https://github.com/openshift-knative/serverless-operator/pull/2575/files#r1537601825

Proposed Changes

For older channels, we ignore micro-releases and only use the initial
version from those streams.
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold for tests

Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgencur
Copy link
Contributor Author

mgencur commented Mar 28, 2024

/retest-required

Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

@mgencur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/415-upstream-e2e-kafka-aws-415 5a5890c link false /test 415-upstream-e2e-kafka-aws-415

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ReToCode
Copy link
Member

/test 412-test-upgrade-aws-412

@ReToCode
Copy link
Member

/override "ci/prow/415-test-upgrade-aws-415"

Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

@ReToCode: Overrode contexts on behalf of ReToCode: ci/prow/415-test-upgrade-aws-415

In response to this:

/override "ci/prow/415-test-upgrade-aws-415"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit c4e53de into openshift-knative:main Mar 29, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants