Skip to content

Conversation

@cardil
Copy link
Member

@cardil cardil commented Dec 9, 2022

Changes

  • Build binaries to Artifacts directory
  • Pin knative style to release-1.8

Closes #285
Unblocks #284

@openshift-ci openshift-ci bot requested review from jrangelramos and lance December 9, 2022 14:09
@cardil cardil added the kind/bug Something isn't working label Dec 9, 2022
@dsimansk
Copy link

dsimansk commented Dec 9, 2022

/approve
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Dec 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 9, 2022
@openshift-merge-robot openshift-merge-robot merged commit 8c38f7e into openshift-knative:release-1.8 Dec 9, 2022
@cardil cardil deleted the bugfix/release-1.8/fix-build branch December 9, 2022 21:48
serverless-qe pushed a commit that referenced this pull request Apr 14, 2023
Signed-off-by: Knative Automation <automation@knative.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved kind/bug Something isn't working lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants