Skip to content

Conversation

@cardil
Copy link
Member

@cardil cardil commented Dec 6, 2022

Changes

  • 🧹 Migrate to buildah action for building multi-arch images

@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cardil cardil force-pushed the feature/midstream-1.6/buildah-action branch from 5ce8ff5 to 2b097e1 Compare December 7, 2022 13:25
@cardil cardil force-pushed the feature/midstream-1.6/buildah-action branch from 2b097e1 to 1855deb Compare December 7, 2022 14:19
@cardil cardil changed the title [release-1.6] Migrate to buildah [release-1.6] 🧹 Migrate to buildah action for building multi-arch images Dec 7, 2022
@cardil cardil marked this pull request as ready for review December 7, 2022 14:20
@openshift-ci openshift-ci bot requested review from lance and zroubalik December 7, 2022 14:20
@cardil
Copy link
Member Author

cardil commented Dec 7, 2022

/unhold

@cardil
Copy link
Member Author

cardil commented Dec 7, 2022

/cc @mgencur

@openshift-ci openshift-ci bot requested a review from mgencur December 7, 2022 14:21
@cardil
Copy link
Member Author

cardil commented Dec 8, 2022

/cc @dsimansk

@openshift-ci openshift-ci bot requested a review from dsimansk December 8, 2022 13:38
@cardil
Copy link
Member Author

cardil commented Dec 8, 2022

/hold

wait for discussion on #270 to resolve

@cardil
Copy link
Member Author

cardil commented Dec 8, 2022

/unhold

@dsimansk
Copy link

dsimansk commented Dec 8, 2022

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Dec 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 8, 2022
@openshift-merge-robot openshift-merge-robot merged commit 357a00c into openshift-knative:release-1.6 Dec 8, 2022
@cardil cardil deleted the feature/midstream-1.6/buildah-action branch December 9, 2022 07:09
@cardil
Copy link
Member Author

cardil commented Dec 9, 2022

/cherrypick release-1.7

@openshift-cherrypick-robot

@cardil: new pull request created: #283

Details

In response to this:

/cherrypick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants