feat: kafka broker now supports all kafka topic config options (knati…

…ve-extensions#3671) (#1031) * feat: kafka broker now supports all kafka topic config options * test: added unit tests, fixed existing tests --------- Signed-off-by: Calum Murray <cmurray@redhat.com>
openshift-knative · Mar 21, 2024 · 2eb9b2f · 2eb9b2f
1 parent 20d343c
commit 2eb9b2f
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 0 deletions.
diff --git a/control-plane/pkg/kafka/topic.go b/control-plane/pkg/kafka/topic.go
@@ -24,13 +24,15 @@ import (
 	"go.uber.org/zap"
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/utils/pointer"
 	"knative.dev/pkg/configmap"
 )
 
 const (
 	DefaultTopicNumPartitionConfigMapKey      = "default.topic.partitions"
 	DefaultTopicReplicationFactorConfigMapKey = "default.topic.replication.factor"
 	BootstrapServersConfigMapKey              = "bootstrap.servers"
+	DefaultTopicConfigPrefix                  = "default.topic.config."
 
 	GroupIDConfigMapKey = "group.id"
 
@@ -97,6 +99,15 @@ func buildTopicConfigFromConfigMap(cm *corev1.ConfigMap) (*TopicConfig, error) {
 		return nil, fmt.Errorf("failed to parse config map %s/%s: %w", cm.Namespace, cm.Name, err)
 	}
 
+	for k, v := range cm.Data {
+		if s := strings.TrimPrefix(k, DefaultTopicConfigPrefix); s != k {
+			if topicDetail.ConfigEntries == nil {
+				topicDetail.ConfigEntries = make(map[string]*string)
+			}
+			topicDetail.ConfigEntries[s] = pointer.String(v)
+		}
+	}
+
 	topicDetail.ReplicationFactor = int16(replicationFactor)
 
 	config := &TopicConfig{

diff --git a/control-plane/pkg/kafka/topic_test.go b/control-plane/pkg/kafka/topic_test.go
@@ -27,6 +27,7 @@ import (
 	"go.uber.org/zap"
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/utils/pointer"
 	eventing "knative.dev/eventing/pkg/apis/eventing/v1"
 
 	kafkatesting "knative.dev/eventing-kafka-broker/control-plane/pkg/kafka/testing"
@@ -441,6 +442,27 @@ func TestTopicConfigFromConfigMap(t *testing.T) {
 				BootstrapServers: []string{"server1:9092", "server2:9092"},
 			},
 		},
+		{
+			name: "All valid, config options provided",
+			data: map[string]string{
+				"default.topic.partitions":               "5",
+				"default.topic.replication.factor":       "8",
+				"bootstrap.servers":                      "server1:9092, server2:9092",
+				"default.topic.config.retention.ms":      "3600",
+				"default.topic.config.max.message.bytes": "68000",
+			},
+			want: TopicConfig{
+				TopicDetail: sarama.TopicDetail{
+					NumPartitions:     5,
+					ReplicationFactor: 8,
+					ConfigEntries: map[string]*string{
+						"retention.ms":      pointer.String("3600"),
+						"max.message.bytes": pointer.String("68000"),
+					},
+				},
+				BootstrapServers: []string{"server1:9092", "server2:9092"},
+			},
+		},
 		{
 			name: "Missing keys 'default.topic.partitions' - not allowed",
 			data: map[string]string{