Skip to content

Move MicroShift CI Doctor doc to edge-context - #197

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
suleymanakbas91:move-microshift-ci-doc
Jun 19, 2026
Merged

Move MicroShift CI Doctor doc to edge-context#197
openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
suleymanakbas91:move-microshift-ci-doc

Conversation

@suleymanakbas91

@suleymanakbas91 suleymanakbas91 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove docs/claude/microshift-ci.md — this is a team triage workflow/procedure doc, not tooling internals
  • Remove its reference from CLAUDE.md Detailed Guides section
  • The doc is being added to edge-context/procedures/ in a companion PR

Test plan

  • npx markdownlint-cli2 '**/*.md' passes with 0 errors
  • No remaining references to docs/claude/microshift-ci.md in the repo

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Removed MicroShift CI Plugin documentation from the available guides.

The microshift-ci.md doc describes team triage workflows and procedures,
not tooling internals. Move it to edge-context/procedures/ where it
belongs alongside other team procedures.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2026
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Removes the MicroShift CI Doctor Plugin documentation: deletes docs/claude/microshift-ci.md (155 lines covering installation, CI phases, daily workflow, and appendices) and removes its corresponding bullet link from the "Detailed Guides" section of CLAUDE.md.

Changes

MicroShift CI Plugin Documentation Removal

Layer / File(s) Summary
Remove plugin guide and index entry
CLAUDE.md, docs/claude/microshift-ci.md
Deletes the 155-line docs/claude/microshift-ci.md file and removes the "MicroShift CI Plugin" bullet from the CLAUDE.md Detailed Guides list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • openshift-eng/edge-tooling#120: Modifies CLAUDE.md in the same "Detailed Guides" area, adding or restructuring guide entries at the same location where this PR removes the MicroShift CI Plugin entry.
  • openshift-eng/edge-tooling#143: Directly introduces the "MicroShift CI Plugin" entry in CLAUDE.md and the docs/claude/microshift-ci.md content that this PR removes.
  • openshift-eng/edge-tooling#181: Updates docs/claude/microshift-ci.md to reference a new report-create-bugs.txt output — the same file this PR deletes entirely.

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore

❌ Failed checks (1 error, 1 warning)

Check name Status Explanation Resolution
No-Injection-Vectors ❌ Error Multiple shell injection and command injection vectors found: eval with unquoted $k variable in sno-deploy/hack/apply.sh and verify.sh; yq eval with unquoted $plugin_name in .claude/hooks/detect-ne... Remove eval statements or properly quote variables; use arrays for kubectl flags instead of eval; escape plugin_name or use safe yq argument passing.
Ai-Attribution ⚠️ Warning PR mentions AI tool usage (Claude Code) but uses Co-Authored-By trailer for AI tool instead of proper Assisted-by or Generated-by trailers required by check. Replace Co-Authored-By with Assisted-by: Claude Opus 4.6 or Generated-by: Claude Opus 4.6 trailer in commit message.
✅ Passed checks (9 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Weak-Crypto ✅ Passed PR removes documentation files only; contains no cryptographic code, weak algorithms (MD5, SHA1, DES, RC4, etc.), custom crypto implementations, or timing-sensitive secret comparisons.
Container-Privileges ✅ Passed PR only modifies documentation files (CLAUDE.md, microshift-ci.md). No container manifests, Kubernetes configs, or files with privileged container settings are changed.
No-Sensitive-Data-In-Logs ✅ Passed This PR removes documentation files (docs/claude/microshift-ci.md and its reference from CLAUDE.md). No new logging code containing passwords, tokens, API keys, PII, session IDs, hostnames, or cust...
No-Hardcoded-Secrets ✅ Passed No hardcoded secrets found. PR contains only documentation, config files, and scripts that properly reference credentials via environment variables without embedding actual secret values.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the MicroShift CI Doctor documentation from this repository and moving it to the edge-context repository, which is fully reflected in the changeset.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@ggiguash

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 5d88c4e into openshift-eng:main Jun 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants